Page MenuHomePhorge
Create Task
Maniphest T15122

Twitch auth provider is not working - old twitch API has been decomissioned
Closed, ResolvedPublic
Actions

Description

the twitch kraken API has been decommissioned and replaced by the helix API. Using the actual auth provider will result in an error asking to upgrade to new API. The actual auth provider is not able to retrieve oauth token neither user information. URLs has changed and users REST endpoint has changed.

The two following patches have fixed the issue on my local install but I'm not sure that the return statement is the arcanist.diff is correct (I'm not a PHP dev)

phorge.diff1 KBDownload

arcanist.diff1 KBDownload

Revisions and Commits

rP Phorge
D25057rPd5040f9a8f49 updating twitch to latest api (Helix)
rARC Arcanist
D25056rARC9e1bb955fac9 updating twitch to latest api (Helix)

Event Timeline

k__nard created this task.Sep 24 2022, 18:30
Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptSep 24 2022, 18:30
k__nard attached a referenced file: F183628: arcanist.diff. (Show Details)Sep 24 2022, 18:36
k__nard attached a referenced file: F183629: phorge.diff. (Show Details)
k__nard added a comment.Sep 24 2022, 18:47

just a small precision, when I said that I'm not sure about the return statement, I meant that it's working but I don't know if there is some need for testing for null data

avivey added a project: Auth (archived).Sep 25 2022, 04:51
avivey subscribed.Sep 28 2022, 18:12

@k__nard: do you mind submitting the diffs as revisions using arc diff?

avivey added a comment.Sep 28 2022, 18:15

also link to the updated Twitch docs about the auth API?

k__nard added a comment.Sep 28 2022, 19:22

ok, I'll try. is there any expectation or format for the git message ?

k__nard added a revision: D25056: updating twitch to latest api (Helix).Oct 9 2022, 18:35
k__nard added a revision: D25057: updating twitch to latest api (Helix).Oct 11 2022, 19:40

ok, done. But I don't know how to fix the unit tests. after running celerity map command what should I do ?

avivey added a comment.Oct 28 2022, 10:32

running celerity map should just fix it. I'll take a look.

Matthew added a commit: rARC9e1bb955fac9: updating twitch to latest api (Helix).Dec 8 2022, 22:39
Matthew added a commit: rPd5040f9a8f49: updating twitch to latest api (Helix).
Cigaryno closed this task as Resolved.Apr 2 2023, 07:37
Cigaryno claimed this task.
avivey removed a project: Auth (archived).May 9 2023, 10:51
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0