Page MenuHomePhorge

Dylsss (Dylan)
User

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Tuesday

  • Clear sailing ahead.

User Details

User Since
Aug 18 2022, 15:27 (100 w, 2 d)
Availability
Available

Recent Activity

Sep 25 2023

Dylsss added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Sep 25 2023, 10:55 · Files

Sep 18 2023

Dylsss updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

PhabricatorFileAttachmentQuery seems to eagerly load the object relation, however since the DestructionEngine extensions run after the object is already deleted, this fails and nothing is returned in the query. Changed to LiskDAO loadAllWhere, which also seems to use less queries in general (due to not eagerly loading), so changed the query in PhabricatorFile as well. Changed mpull to foreach per suggestion.

Sep 18 2023, 20:18 · Files
Dylsss added inline comments to D25051: Destroy file attachments when file is deleted, or object is deleted.
Sep 18 2023, 19:24 · Files

Sep 17 2023

Dylsss updated the summary of D25051: Destroy file attachments when file is deleted, or object is deleted.
Sep 17 2023, 23:33 · Files
Dylsss merged T15618: Lots of "Unknown Object"s referenced from revisions into T15110: File reference not removed when file is deleted.
Sep 17 2023, 23:32 · Files, Bug Reports
Dylsss merged task T15618: Lots of "Unknown Object"s referenced from revisions into T15110: File reference not removed when file is deleted.
Sep 17 2023, 23:32 · Differential, Bug Reports
Dylsss edited projects for D25051: Destroy file attachments when file is deleted, or object is deleted, added: Files; removed Files (archived).
Sep 17 2023, 23:31 · Files
Dylsss updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

Commit fixup/update author details

Sep 17 2023, 23:30 · Files
Dylsss updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

Organised attachment deletion from the file side into the File object and deletion from the object side into the destruction engine extension. Also updated the SQL patch date in the file name.

Sep 17 2023, 22:59 · Files

Apr 24 2023

Dylsss added a comment to D25129: Fix PHP 8.1 "strlen(null)" exception in PhutilOpaqueEnvelope.php.

Thanks for accepting. As I have been puzzled by arc for many years now, is there a way to merge via the web UI? arc land D25129 on a shell tells me that Branch "D25129" does not exist in the local working copy, likely because I've reset stuff here.

There is no way to merge from the web UI.

Apr 24 2023, 02:24
Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.

(Ignored unrelated build failures, see fix: D25133)

Apr 24 2023, 01:57 · Remarkup
Dylsss requested review of D25133: Countdown: fix PhutilMissingSymbolException.
Apr 24 2023, 00:31
Dylsss updated the diff for D25052: Add and use new RemarkupMetadata class.

Rebased and applied suggested changes

Apr 24 2023, 00:27 · Remarkup
Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#4102, @Dylsss wrote:

I reverted to a previous commit (36dba82224de1b64bf571ebae5e944ce8a02e7c2) and still get this error when uploading from the remarkup toolbar upload button. So I don't think it is related to this change.

Apr 24 2023, 00:05 · Remarkup

Apr 23 2023

Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
WARNING: After this change, in my JavaScript console I can see this exception: Error: JX.DOM.scry(<yuck>, ...): first argument must be a DOM node. - I do not understand a shit about Javelin so I really don't know what does it mean
Apr 23 2023, 23:33 · Remarkup

Mar 27 2023

valerio.bozzolan awarded T15147: Prefill tags when user opens new task form in new tab from workboard column a 100 token.
Mar 27 2023, 06:23 · Projects, Workboard

Mar 23 2023

valerio.bozzolan awarded D25068: Workboard: improve the Create Task link to mention the Project slug a Like token.
Mar 23 2023, 11:58
Dylsss added a comment to D25067: Change erroneous loose comparison to strict comparison in tab panels.

I'm not sure I can reproduce this issue before this patch.

W32

Mar 23 2023, 04:16
Dylsss retitled D25068: Workboard: improve the Create Task link to mention the Project slug from Add project PHID to tags query param in create action URLs on workboard column menus to Add project slug to tags query param in create action URLs on workboard column menus.
Mar 23 2023, 04:05
Dylsss updated the diff for D25068: Workboard: improve the Create Task link to mention the Project slug.

Use project slug

Mar 23 2023, 04:04

Mar 22 2023

Dylsss planned changes to D25051: Destroy file attachments when file is deleted, or object is deleted.
Mar 22 2023, 23:21 · Files

Mar 2 2023

Krinkle awarded D25068: Workboard: improve the Create Task link to mention the Project slug a Love token.
Mar 2 2023, 17:26

Feb 21 2023

Dylsss updated the summary of D25068: Workboard: improve the Create Task link to mention the Project slug.
Feb 21 2023, 03:07
Dylsss updated the summary of D25068: Workboard: improve the Create Task link to mention the Project slug.
Feb 21 2023, 03:07
Dylsss added a revision to T15147: Prefill tags when user opens new task form in new tab from workboard column: D25068: Workboard: improve the Create Task link to mention the Project slug.
Feb 21 2023, 03:06 · Projects, Workboard
Dylsss added a task to D25068: Workboard: improve the Create Task link to mention the Project slug: T15147: Prefill tags when user opens new task form in new tab from workboard column.
Feb 21 2023, 03:06
Dylsss requested review of D25068: Workboard: improve the Create Task link to mention the Project slug.
Feb 21 2023, 03:06
Dylsss created T15147: Prefill tags when user opens new task form in new tab from workboard column.
Feb 21 2023, 02:56 · Projects, Workboard
Dylsss updated the diff for D25052: Add and use new RemarkupMetadata class.

Rebased on master, ran bin/celerity map to resolve merge conflict.

Feb 21 2023, 00:23 · Remarkup

Feb 20 2023

Dylsss retitled D25067: Change erroneous loose comparison to strict comparison in tab panels from Change erroneous loose comparison to strict comparison
Feb 20 2023, 23:42
Dylsss added a revision to T15146: Dashboards: Tab panel sometimes displays the content of two tabs: D25067: Change erroneous loose comparison to strict comparison in tab panels.
Feb 20 2023, 23:41 · Dashboards, Bug Reports
Dylsss added a task to D25067: Change erroneous loose comparison to strict comparison in tab panels: T15146: Dashboards: Tab panel sometimes displays the content of two tabs.
Feb 20 2023, 23:41
Dylsss requested review of D25067: Change erroneous loose comparison to strict comparison in tab panels.
Feb 20 2023, 23:40
Dylsss created T15146: Dashboards: Tab panel sometimes displays the content of two tabs.
Feb 20 2023, 22:59 · Dashboards, Bug Reports

Feb 17 2023

Dylsss added Q38: Database tables documentation? (Answer 33).
Feb 17 2023, 20:08

Nov 29 2022

Dylsss added a comment to Q28: How can I add a "Fix Version" to a task? (Answer 22).

Yes, you could also use milestones and tag the task with that milestone. For example, this is done at Wikimedia's Phabricator: https://phabricator.wikimedia.org/project/subprojects/5539/, where milestones are used to track changes associated with a task.

Nov 29 2022, 00:49

Nov 28 2022

Dylsss added a member for Trusted Contributors: valerio.bozzolan.
Nov 28 2022, 15:24

Nov 25 2022

Dylsss added Q28: How can I add a "Fix Version" to a task? (Answer 22).
Nov 25 2022, 19:37

Oct 16 2022

Dylsss added a comment to T15105: Cannot upload new mockups via Pholio.

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )
Oct 16 2022, 15:32 · phorge.it install (DEPRECATED)

Oct 13 2022

Dylsss added a comment to D25052: Add and use new RemarkupMetadata class.
In D25052#1750, @avivey wrote:

I'd expect some PHP code to actually attach the files from attachedFilePHIDs to the relevant object, but I don't see it in this diff. Is that already happening somehow?

It's done here: https://we.phorge.it/source/phorge/browse/master/src/applications/transactions/editor/PhabricatorApplicationTransactionEditor.php;5aa159a83013fca3a72f5c6d2c493c117fbbf83b$2296

Oct 13 2022, 14:11 · Remarkup

Sep 28 2022

Dylsss created T15125: Unknown edge constant "26"! when deleting a file with old attachment edges.
Sep 28 2022, 21:47 · Affects-Wikimedia, Files, Bug Reports

Sep 19 2022

Dylsss added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

Auto file attachments are also not working when editing a comment.

Sep 19 2022, 19:16 · Files, Remarkup
Dylsss updated the diff for D25052: Add and use new RemarkupMetadata class.

Differentiate between metadata of different text areas using node ID. e.g., new comment text areas and text areas in the edit comment dialog.

Sep 19 2022, 01:58 · Remarkup

Sep 18 2022

Dylsss added a task to D25052: Add and use new RemarkupMetadata class: T15106: "Upload file" in remarkup text fields should attach by default .
Sep 18 2022, 17:06 · Remarkup
Dylsss added a revision to T15106: "Upload file" in remarkup text fields should attach by default : D25052: Add and use new RemarkupMetadata class.
Sep 18 2022, 17:06 · Files, Remarkup
Dylsss updated the diff for D25052: Add and use new RemarkupMetadata class.

ran celerity map again

Sep 18 2022, 17:02 · Remarkup
Dylsss requested review of D25052: Add and use new RemarkupMetadata class.
Sep 18 2022, 16:59 · Remarkup

Sep 12 2022

Dylsss updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

arc liberate

Sep 12 2022, 18:08 · Files
Dylsss updated the diff for D25051: Destroy file attachments when file is deleted, or object is deleted.

Linting

Sep 12 2022, 18:07 · Files
Dylsss added a revision to T15110: File reference not removed when file is deleted: D25051: Destroy file attachments when file is deleted, or object is deleted.
Sep 12 2022, 13:26 · Files, Bug Reports
Dylsss added a task to D25051: Destroy file attachments when file is deleted, or object is deleted: T15110: File reference not removed when file is deleted.
Sep 12 2022, 13:26 · Files
Dylsss requested review of D25051: Destroy file attachments when file is deleted, or object is deleted.
Sep 12 2022, 13:25 · Files

Aug 24 2022

Dylsss added a project to T15110: File reference not removed when file is deleted: Files (archived).
Aug 24 2022, 10:23 · Files, Bug Reports

Aug 23 2022

Dylsss created T15110: File reference not removed when file is deleted.
Aug 23 2022, 19:07 · Files, Bug Reports

Aug 18 2022

Dylsss added a comment to T15106: "Upload file" in remarkup text fields should attach by default .

https://phabricator.wikimedia.org/D1203 is my fix for this issue at Wikimedia's install.

Aug 18 2022, 15:32 · Files, Remarkup