Page MenuHomePhorge

Unmark Audit as a required application
Closed, ResolvedPublic

Description

Audit will not work with Diffusion uninstalled. It's weird to see Diffusion not being required and Audit required which is a subcomponent of Diffusion. Example.

  • Set canUninstall in PhabricatorAuditApplication.php to true
  • Add this rule:

If Audit will be uninstalled, automatically uninstall Diffusion too.
The user must have the Can Configure Application and Can Use Application permissions in both applications.

Event Timeline

Cigaryno triaged this task as Low priority.Apr 3 2023, 12:02

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

For archaeologists: canUninstall = false for Audit got set in rP11861265fe94fa97e4d0563c5bdb7b8cac27282d

I have seen the canUninstall setting before in PhabricatorAuditApplication.php. The only important thing is to set this value to true. We also need to use this rule:

If Audit will be uninstalled, automatically uninstall Diffusion too.
The user must have the Can Configure Application and Can Use Application permissions in both applications.

.. and vice versa

.. and vice versa

I'd disagree here if I understand you correctly.
I want my all of my users to browse code repositories and their commits in a web browser (Diffusion), basically "read-only".
I do not want any of my users to perform post-publish code reviews (Audit).