Can someone change ...

In D25479#13906, @avivey wrote:

Is this the only place where we have a "Page size" exposed in the search?

Is this the only place where we have a "Page size" exposed in the search?

Let the Purge begin!

In D25388#13885, @avivey wrote:

In D25388#13843, @Matthew wrote:

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

I feel like that kind of task will just fall down into oblivion....

• rm commented out code

In D25388#13843, @Matthew wrote:

I like renaming the function!

We should probably have a timeline for removing the old function. Do we have a task for that?

Hmm I guess the Test Plan should also cover testing with Conduit. Not sure this may shake something up.

When a phriction markup page is generated , its synchronous, when a diffusion markup page is generated it's asynchronous.
This is going to take a bit of thought.

Another option would be to extend the class PhabricatorSearchTextField and make the new class PhabricatorSearchPageSizeField only overwrite function getDefaultValue(), however class PhabricatorSearchTextField is marked as final and I am reluctant to change that.

In T15671#14420, @avivey wrote:

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

Maybe this can be done as an extension:

• Abstract the "profile picture provider"
• Allow an extension to write a Gravatar one

There are currently 2-3 sources, so maybe there is some abstraction:

• pokemon-style silhouette
• Character with background (generated from username)
• Upload Picture

I like renaming the function!

1 comment...

The feature was removed for performance and private concerns. I thought Gravatar was alread dead.

I aslo don't see the point of this feature, but that's another issue.

I don't see the point in having this feature. What is it for?

Should this be configurable and behind a feature flag, as some Phorge installations may not want this (plus may slow down performance a little bit)?

This code change adds a small star to handles of new user accounts:

Fix variable names

Obviously, any fixes should be in ManiphestTransactionEditor and not spill into generic parent PhabricatorApplicationTransactionEditor.

Historical references: rP69eab4196de462e42b07b60e2b52071631f4a3c8 and rP4041a7e0f66406dbaa31faa3807d50833b7c7efd (which didn't help much).

• update some copy

• cleanup

Extending this task to include support for PHP 8.3 which is due to be released today.

Nobody seems interested in my concern, so, hard approve :) Thanks

Thanks for your help @valerio.bozzolan, It appears I had missed that part!..oops...I'll give that a try over the weekend.

Translatewiki finally processed the rebrand a few days ago, as part of https://phabricator.wikimedia.org/T318763

I didn't give up on this one and, since I prefer using the dark theme on my day to day activity, I know there are a lot of work to be done to reach something nice.
I'll try to move forward on next weeks...

My steps to reproduce are wrong / unclear / not always happening.

This partially fixes the problem:

In D25374#10923, @Matthew wrote:

Please fix unit errors

In D25362#13135, @speck wrote:

Is the list of PHIDs referring to what types of objects that it creates? Is the expectation that each PHID type corresponds to exactly one Application? Maybe some additional text on that page to explain more what PHIDs mean in this context.

Probably this happens while creating a new project and doing that thing again 🤔

Can no longer replicate the fault.

I can no longer replicate the fault, so am going to scrap this one.