Page MenuHomePhorge

l2dy (Zero King)
UserEmail Not Verified

Projects

Today

  • Clear sailing ahead.

Tomorrow

  • Clear sailing ahead.

Friday

  • Clear sailing ahead.

User Details

User Since
Oct 4 2023, 01:53 (33 w, 5 h)
Availability
Available

Recent Activity

Apr 9 2024

l2dy created T15775: Add more languages supported by Pygments for syntax highlighting.
Apr 9 2024, 16:12 · Phorge

Mar 6 2024

l2dy added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

Thanks for the reminder!

Mar 6 2024, 16:04
l2dy closed D25478: Use predictable filenames when downloading raw diffs from a revision.
Mar 6 2024, 16:04
l2dy committed rP10a3f4fa192d: Use predictable filenames when downloading raw diffs from a revision (authored by dkl).
Use predictable filenames when downloading raw diffs from a revision
Mar 6 2024, 16:04
l2dy updated the diff for D25478: Use predictable filenames when downloading raw diffs from a revision.

Update comments

Mar 6 2024, 15:57

Feb 24 2024

l2dy awarded D25537: Update PHP versions in install guide: Remove 5, Add 8. a Cup of Joe token.
Feb 24 2024, 12:54

Dec 6 2023

l2dy closed Q80: Bug: passing null to strlen in readLocalArcConfig as resolved.
Dec 6 2023, 14:24 · Arcanist

Dec 4 2023

l2dy added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.

id, vs and /new/ in URL all affect content of the generated file.

Dec 4 2023, 16:09

Dec 3 2023

l2dy added a comment to D25478: Use predictable filenames when downloading raw diffs from a revision.
In D25478#13957, @speck wrote:

What do you think about keeping the current naming scheme but whitelisting a handful of query params to use instead of using them all? The timestamp adds noise and it's probably nice to see the ID of the diff in the filename, e.g. D25478.id1541.diff? Maybe just allow the the id parameter and regex that it's value is just a string of numbers.

Dec 3 2023, 11:04

Nov 26 2023

l2dy updated the summary of D25478: Use predictable filenames when downloading raw diffs from a revision.
Nov 26 2023, 15:38
l2dy requested review of D25478: Use predictable filenames when downloading raw diffs from a revision.
Nov 26 2023, 15:35

Nov 25 2023

l2dy added a comment to T15675: Visually indicate new user accounts.

Should this be configurable and behind a feature flag, as some Phorge installations may not want this (plus may slow down performance a little bit)?

Nov 25 2023, 13:34 · Feature Requests

Nov 20 2023

valerio.bozzolan awarded Q86: Policy lifecycle of security tasks a Love token.
Nov 20 2023, 22:15 · Discussion Needed

Nov 13 2023

l2dy closed D25467: Align logo image and text in site header.
Nov 13 2023, 09:56
l2dy committed rPaa8af1d79e8b: Align logo image and text in site header.
Align logo image and text in site header
Nov 13 2023, 09:56
l2dy added a comment to D25467: Align logo image and text in site header.

Uh! Nice!

Interestingly this CSS change only has effects on Chromium 119 and it does not change anything in my Mozilla Firefox 118. Can you give a quick look?

Nov 13 2023, 09:46
l2dy added a comment to Q79: Is arc.land.onto.default configuration deprecated? (Answer 107).

This is related to https://secure.phabricator.com/T13546. "classic" Arcanist workflows were being upgraded to Toolsets, but the migration was not complete. See comments starting with TOOLSETS: , e.g. in ArcanistConfigurationSource.php.

Nov 13 2023, 01:18
l2dy closed D25470: Initialize static variable to make linter happy.
Nov 13 2023, 00:52
l2dy committed rP361fcd0cac36: Initialize static variable to make linter happy.
Initialize static variable to make linter happy
Nov 13 2023, 00:52
l2dy closed D25469: Fix reentrancy guard in setDebugTimeLimit().
Nov 13 2023, 00:51
l2dy committed rP486fc95b29fd: Fix reentrancy guard in setDebugTimeLimit().
Fix reentrancy guard in setDebugTimeLimit()
Nov 13 2023, 00:51
l2dy closed D25468: Fix typo in DiffusionLowLevelGitRefQuery.
Nov 13 2023, 00:50
l2dy committed rP4535e8753c8b: Fix typo in DiffusionLowLevelGitRefQuery.
Fix typo in DiffusionLowLevelGitRefQuery
Nov 13 2023, 00:50

Nov 12 2023

l2dy requested review of D25470: Initialize static variable to make linter happy.
Nov 12 2023, 18:21
l2dy requested review of D25469: Fix reentrancy guard in setDebugTimeLimit().
Nov 12 2023, 18:12
l2dy requested review of D25468: Fix typo in DiffusionLowLevelGitRefQuery.
Nov 12 2023, 17:49
l2dy asked Q86: Policy lifecycle of security tasks.
Nov 12 2023, 16:17 · Discussion Needed
l2dy closed D25464: Enforce viewable MIME types config on PDF documents.
Nov 12 2023, 16:13
l2dy committed rP16d9cc12af45: Enforce viewable MIME types config on PDF documents.
Enforce viewable MIME types config on PDF documents
Nov 12 2023, 16:13
l2dy added inline comments to D25464: Enforce viewable MIME types config on PDF documents.
Nov 12 2023, 16:00
l2dy updated the diff for D25464: Enforce viewable MIME types config on PDF documents.

Phrasing

Nov 12 2023, 15:57
l2dy added inline comments to D25464: Enforce viewable MIME types config on PDF documents.
Nov 12 2023, 15:51
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 12 2023, 15:42 · Security, Phorge
l2dy added a comment to D25464: Enforce viewable MIME types config on PDF documents.
In D25464#13372, @speck wrote:

This will require documentation of some sort, specifically for the upgrade notes to indicate that if someone relies on rendering PDFs currently then after upgrading they would need to update that configuration.

I think making a task to document the issue and linking in the release notes would be a good approach and what upstream would typically have done.

Nov 12 2023, 15:40
l2dy closed Q81: Documentation for "Restarting Phabricator" is missing as resolved.
Nov 12 2023, 10:58 · Phorge
l2dy added Q81: Documentation for "Restarting Phabricator" is missing (Answer 110).
Nov 12 2023, 10:58
l2dy closed Q85: How does amending author information work with `arc land`? as resolved.
Nov 12 2023, 10:57
l2dy requested review of D25467: Align logo image and text in site header.
Nov 12 2023, 09:41
l2dy added a revision to T15666: Align logo image and text in site header: D25467: Align logo image and text in site header.
Nov 12 2023, 09:41 · Phorge
l2dy updated the task description for T15666: Align logo image and text in site header.
Nov 12 2023, 09:30 · Phorge
l2dy updated the task description for T15666: Align logo image and text in site header.
Nov 12 2023, 09:21 · Phorge
l2dy created T15666: Align logo image and text in site header.
Nov 12 2023, 09:20 · Phorge
l2dy updated the summary of D25464: Enforce viewable MIME types config on PDF documents.
Nov 12 2023, 07:08
l2dy updated the summary of D25464: Enforce viewable MIME types config on PDF documents.
Nov 12 2023, 06:13

Nov 11 2023

l2dy added a comment to D25464: Enforce viewable MIME types config on PDF documents.
In D25464#13328, @speck wrote:

The Referenced Files section of this diff looks like someone is looking for a vulnerability. Any idea what’s happening here?

Nov 11 2023, 23:18
l2dy added a comment to Q85: How does amending author information work with `arc land`? (Answer 109).

arc diff throws an error and arc land ignores it. Instead of getting it to work with Differential, I'm amending the commit manually with git commit --amend -s after arc land --hold.

Nov 11 2023, 23:16
l2dy closed D25462: Fix view policy inheritance on image transforms.
Nov 11 2023, 23:10
l2dy committed rP005fea5a14f4: Fix view policy inheritance on image transforms (authored by dkl).
Fix view policy inheritance on image transforms
Nov 11 2023, 23:10
l2dy updated the diff for D25462: Fix view policy inheritance on image transforms.

Update commit message

Nov 11 2023, 23:07
l2dy updated the diff for D25464: Enforce viewable MIME types config on PDF documents.

Update config description

Nov 11 2023, 10:45
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 11 2023, 08:41 · Security, Phorge
l2dy added a comment to Q83: Pull security fixes from Mozilla's fork (Answer 108).

Mozilla's fixes were quick but not in good quality for direct submission to Phorge. I have adapted or rewritten two of the changes into D25462 and D25464.

Nov 11 2023, 08:25
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 11 2023, 08:13 · Security, Phorge
l2dy requested review of D25464: Enforce viewable MIME types config on PDF documents.
Nov 11 2023, 08:13
l2dy added a comment to D25462: Fix view policy inheritance on image transforms.

Before landing this change, I would like to know the right way to credit both the original author and my modifications with Arcanist (Q85).

Nov 11 2023, 02:43
l2dy closed D25463: Correct default database prefix in documentation.
Nov 11 2023, 02:33
l2dy committed rPc97a50472c5b: Correct default database prefix in documentation.
Correct default database prefix in documentation
Nov 11 2023, 02:33
l2dy updated the diff for D25463: Correct default database prefix in documentation.

Reword

Nov 11 2023, 02:26
l2dy requested review of D25463: Correct default database prefix in documentation.
Nov 11 2023, 02:24
l2dy added inline comments to D25462: Fix view policy inheritance on image transforms.
Nov 11 2023, 00:34
l2dy added inline comments to D25462: Fix view policy inheritance on image transforms.
Nov 11 2023, 00:27

Nov 10 2023

l2dy asked Q85: How does amending author information work with `arc land`?.
Nov 10 2023, 18:01
l2dy changed the visibility for Q83: Pull security fixes from Mozilla's fork.
Nov 10 2023, 16:40 · Security, Phorge
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 10 2023, 16:08 · Security, Phorge
l2dy added a comment to Q83: Pull security fixes from Mozilla's fork.

@valerio.bozzolan If you didn't get an answer, try asking in #conduit. I didn't realize that # needs to be quoted in Remarkup. 😢

Nov 10 2023, 16:05 · Security, Phorge
l2dy added a comment to D25462: Fix view policy inheritance on image transforms.

@valerio.bozzolan Upstream removed code that enforces $always_visible when $file->getIsProfileImage() is true in PhabricatorFileQuery.php, but I'm afraid that this change may break other things, so I did not apply it here, but on the other hand kept the description of "Image will be Public".

Nov 10 2023, 15:58
l2dy updated the summary of D25462: Fix view policy inheritance on image transforms.
Nov 10 2023, 15:57
l2dy updated the diff for D25462: Fix view policy inheritance on image transforms.

Mention upstream commit

Nov 10 2023, 15:56
l2dy added a comment to Q83: Pull security fixes from Mozilla's fork.

It would be great if Mozilla's team could join forces with Phorge. Would you (the core team) contact them in #conduit on chat.mozilla.org and mozilla.slack.com?

Nov 10 2023, 15:39 · Security, Phorge
l2dy updated the diff for D25462: Fix view policy inheritance on image transforms.

Fix lint warnings

Nov 10 2023, 15:13
l2dy requested review of D25462: Fix view policy inheritance on image transforms.
Nov 10 2023, 15:10
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 10 2023, 13:39 · Security, Phorge
l2dy added a comment to T15045: Support SSL/TLS for MariaDB connections.

I have reviewed it and made some comments. On a remotely related topic, TLS handshakes are expensive and persistent connections can reduce latency and server load by reusing TLS connections, so maybe we should make it configurable outside of cluster.databases as well.

Nov 10 2023, 13:07 · Security

Nov 9 2023

l2dy closed D25459: Fix doc link to Restarting Phorge.
Nov 9 2023, 11:34
l2dy committed rPce5e0f3e333e: Fix doc link to Restarting Phorge.
Fix doc link to Restarting Phorge
Nov 9 2023, 11:34

Nov 8 2023

l2dy requested review of D25459: Fix doc link to Restarting Phorge.
Nov 8 2023, 14:15

Nov 6 2023

l2dy added a project to Q83: Pull security fixes from Mozilla's fork: Phorge.
Nov 6 2023, 13:35 · Security, Phorge
l2dy updated the question details for Q83: Pull security fixes from Mozilla's fork.
Nov 6 2023, 13:20 · Security, Phorge
l2dy asked Q83: Pull security fixes from Mozilla's fork.
Nov 6 2023, 13:20 · Security, Phorge

Nov 5 2023

l2dy asked Q82: Consider replacing MyISAM with InnoDB?.
Nov 5 2023, 16:58 · Phorge
avivey awarded Q81: Documentation for "Restarting Phabricator" is missing a Grey Medal token.
Nov 5 2023, 07:42 · Phorge
l2dy asked Q81: Documentation for "Restarting Phabricator" is missing.
Nov 5 2023, 04:00 · Phorge
l2dy asked Q80: Bug: passing null to strlen in readLocalArcConfig.
Nov 5 2023, 01:38 · Arcanist

Oct 31 2023

l2dy asked Q79: Is arc.land.onto.default configuration deprecated?.
Oct 31 2023, 11:36 · Arcanist