- User Since
- Oct 4 2023, 01:53 (8 w, 6 d)
id, vs and /new/ in URL all affect content of the generated file.
Sun, Dec 3
Sun, Nov 26
Sat, Nov 25
Should this be configurable and behind a feature flag, as some Phorge installations may not want this (plus may slow down performance a little bit)?
Mon, Nov 20
Mon, Nov 13
This is related to https://secure.phabricator.com/T13546. "classic" Arcanist workflows were being upgraded to Toolsets, but the migration was not complete. See comments starting with TOOLSETS: , e.g. in ArcanistConfigurationSource.php.
Sun, Nov 12
Sat, Nov 11
arc diff throws an error and arc land ignores it. Instead of getting it to work with Differential, I'm amending the commit manually with git commit --amend -s after arc land --hold.
Update commit message
Update config description
Before landing this change, I would like to know the right way to credit both the original author and my modifications with Arcanist (Q85).
Fri, Nov 10
@valerio.bozzolan If you didn't get an answer, try asking in #conduit. I didn't realize that # needs to be quoted in Remarkup. 😢
@valerio.bozzolan Upstream removed code that enforces $always_visible when $file->getIsProfileImage() is true in PhabricatorFileQuery.php, but I'm afraid that this change may break other things, so I did not apply it here, but on the other hand kept the description of "Image will be Public".
Mention upstream commit
It would be great if Mozilla's team could join forces with Phorge. Would you (the core team) contact them in Conduit on chat.mozilla.org and mozilla.slack.com?
Fix lint warnings
I have reviewed it and made some comments. On a remotely related topic, TLS handshakes are expensive and persistent connections can reduce latency and server load by reusing TLS connections, so maybe we should make it configurable outside of cluster.databases as well.