Page MenuHomePhorge

PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer
Open, Needs TriagePublic

Description

If you try to view a subversion commit, you get a Runtime Exception with the stacktrace below :

PHP message: [2023-08-16 15:52:53] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]; 
PHP message: arcanist(head=master, ref.master=df6c315ace5f), phorge(head=master, ref.master=9fa9aa30b940); 
PHP message:   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommitData.php:134]; 
PHP message:   #1 <#2> PhabricatorRepositoryCommitData::getCommitterString() called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:528]; 
PHP message:   #2 <#2> PhabricatorRepositoryCommit::getRawCommitterStringForDisplay() called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:495]; 
PHP message:   #3 <#2> PhabricatorRepositoryCommit::newCommitCommitterView(PhabricatorUser) called at [<phorge>/src/applications/diffusion/controller/DiffusionCommitController.php:636]; 
PHP message:   #4 <#2> DiffusionCommitController::buildPropertyListView(PhabricatorRepositoryCommit, PhabricatorRepositoryCommitData, array) called at [<phorge>/src/applications/diffusion/controller/DiffusionCommitController.php:186]; 
PHP message:   #5 <#2> DiffusionCommitController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]; 
PHP message:   #6 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]; 
PHP message:   #7 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751];