Paths

Table of Contentst

Differential D25481

Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
ClosedPublic
Actions

Authored by aklapper on Nov 28 2023, 12:47.

Tags

None

Referenced Files

	F2990055: D25481.1740168369.diff
	Thu, Feb 20, 20:06

	F2990054: D25481.1740168369.diff
	Thu, Feb 20, 20:06

	F2989953: D25481.1740167829.diff
	Thu, Feb 20, 19:57

	F2982351: D25481.1739954495.diff
	Tue, Feb 18, 08:41

	F2947533: D25481.1738478531.diff
	Sat, Feb 1, 06:42

	F2945405: D25481.1738315129.diff
	Thu, Jan 30, 09:18

	F2942558: D25481.1738119722.diff
	Tue, Jan 28, 03:02

	F2938314: D25481.1737994151.diff
	Sun, Jan 26, 16:09

View All 12 Files

Subscribers

valerio.bozzolan

Details

Reviewers

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file

Commits

rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:59]

Closes T15678

Test Plan

Add and remove alt text on an image file; then go to /feed/query/all/

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

aklapper created this revision.Nov 28 2023, 12:47

Owners added a reviewer: O1: Blessed Committers.Nov 28 2023, 12:47

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 28 2023, 12:47

aklapper requested review of this revision.Nov 28 2023, 12:47

Harbormaster completed remote builds in B958: Diff 1547.Nov 28 2023, 12:47

speck accepted this revision.Nov 28 2023, 13:03

This revision is now accepted and ready to land.Nov 28 2023, 13:03

Closed by commit rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file. · Explain WhyNov 28 2023, 13:52

This revision was automatically updated to reflect the committed changes.

aklapper added a commit: rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

files/

xaction/

PhabricatorFileAltTextTransaction.php

4 lines

O1: Blessed Committers

Diff 1548

src/applications/files/xaction/PhabricatorFileAltTextTransaction.php

Loading...