Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
ClosedPublic
Actions

Authored by aklapper on Nov 28 2023, 12:47.

Details

Reviewers

speck

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15678: PHP 8.1 "strlen(null)" exception after removing custom alt text from image file

Commits

rPc3850a3c1530: Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:59]

Closes T15678

Test Plan

Add and remove alt text on an image file; then go to /feed/query/all/