Page MenuHomePhorge

Fix PHP 8.1 "strlen(null)" exception removing custom alt text from image file
ClosedPublic

Authored by aklapper on Nov 28 2023, 12:47.
Tags
None
Referenced Files
F3302467: D25481.1743067348.diff
Wed, Mar 26, 09:22
F3300825: D25481.1743048564.diff
Wed, Mar 26, 04:09
F3299670: D25481.1743025898.diff
Tue, Mar 25, 21:51
F3294461: D25481.1742935405.diff
Mon, Mar 24, 20:43
F3289931: D25481.1742855318.diff
Sun, Mar 23, 22:28
F3249314: D25481.1742285627.diff
Mon, Mar 17, 08:13
F3216811: D25481.1741716445.diff
Mon, Mar 10, 18:07
F2990055: D25481.1740168369.diff
Feb 20 2025, 20:06

Details

Summary

strlen() was used in Phabricator to check if a generic value is a non-empty string.
This behavior is deprecated since PHP 8.1. Phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

ERROR 8192: strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [/var/www/html/phorge/phorge/src/applications/files/xaction/PhabricatorFileAltTextTransaction.php:59]

Closes T15678

Test Plan

Add and remove alt text on an image file; then go to /feed/query/all/

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable