Shade colors are currently identical whatever user's theme (White, Dark, etc...) whereas, in most situation
this is not something desirable. For instance :
- In dark mode, the font color is usually light (white, light grey, etc...) whereas current shade colors are light too, leading to a bad contrast
- In dark mode, maniphest's tags are a little bit agressive
- ...
Since I've no idea about how shade colors were derivated from base colors (I tried to find magic rules/relations without success),
here are the operations to I applied to generate new shade colors :
- Swap sh-light[COLOR]border and sh-[COLOR]border
- Swap sh-[COLOR]text and sh-[COLOR]background
- Decrease sh-[COLOR]text ligthness by 10 to get sh-[COLOR]icon
Below, some comparaisons :
Before | After |
---|---|
Obvisouly, this is only a proposal but, as far as I can see, it looks better. Unfortunately, since these shade colors are used in many places,
this isn't easy to check against all potential regressions...
Fix T15056