Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?
I think it's only used for working on PHP on Windows; The equivalent xhpast isn't included, presumably because compiling stuff on Windows is harder.
My argument for this is that the normal way to install arcanist is git clone, which downloads all the history (and 95% of users won't need this particular file).

The ".then()" part is pure hackness; The async/await is the sane way to do async programming.

oh, for this one we can just ignore it. arc only shows these for new lines

I'm happy about the JS stuff, and I'm ok with any UI solution here.
I'll try to see if there's config for the jshint to allow async.

We can probably just pull the JsShrink fix in for now, and later replace both it and jsxmin (which I'll bet nobody have) with something else that is maintained, like JShrink.

In D25536#15408, @valerio.bozzolan wrote:

(Just to clarify, and sorry if late comment again - I was proposing to avoid to add buttons, and simply auto-select and auto-copy the input text the first time it receives a click. Bonus: with "copied" message feedback - I have untested this sorry)

Our policy in general is "support things way after the go EOL", but with the cost of supporting IE 11 (this kind of hell), I think we can make an exception and throw it under the bus. Worst case, we're talking about an error in the logs and "nothing happening" from the user POV, right?

Yes, I insist on using the absolute required minimum of Promise-style coding.
I don't know if we have any other example of a Promise-based API used - there might be an example somewhere on how to break away from it and go back to sane code.

Don't do that thing to the JS file. To add a notification, use the existing notification feature we already have - see https://we.phorge.it/uiexample/view/PhabricatorNotificationUIExample/ (https://we.phorge.it/source/phorge/browse/master/src/applications/uiexample/examples/PhabricatorNotificationUIExample.php).

I'm not against replacing the mechanism - It's just that the original task description doesn't specify why that would be good (i.e., what the benefit would be).
That's clear from the discussion now, but should generally be included in the ticket description - the "describe "what", not "how"" principle.

Ok, I don't understand the specifics of css-vars, but if they're better, they're better.

also, adding this file in src/extensions/ will let you have css/js files from src/extensions/rsrc/ loaded automatically:

to have a working dev server when developing js - at the moment I have to ./bin/celerity map after every change to js and css to see my changes...

Looks to me that the existing system is better at providing Themes? It allows real code, inheritance, etc. to set variable values.
That is, I think Extension Themes are better off writing PHP Post-Processor rather then CSS vars.

Oh, totally possible that I forgot to update it :)

We already support PHP 8...

maybe include "allow extensions to provide themes" here...

We should pack the fonts internally, not use an external source.
We pack all the assets we use, for cases where network access is limited by infosec types or by other reasons.
Just serving few font files from the site would be much simpler, and the extra bandwidth requirements are miniscule anyway.

Nice! Is there a recording of the talk?

In T15630#15574, @sirocyl wrote:

As far as fonts are concerned, while we should decide on a new default font, should this be a configurable? Should we make an item (in Config for defaults, and in Settings for users' choice) to change the UI font on an installation?

To be fair, it's possible that most of the arc features work for Windows users that don't use PHP. Or at least, arc diff might work for some setup of lint/unit configuration.

D25532 should fix this...

I broke it at D25530; Thanks @philj0st

Sorry, I just assumed arc land will catch it...

In case of what?

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

I'm triaging as "wishlist" for now, but realistically - I don't believe will ever reach a point where we'll try to fix this -- see https://secure.phabricator.com/T13154 for discussion.

Marking as "obsolete" because this has graduated to T15722

In T15726#15436, @Matthew wrote:

My concern with removing the applications outright is that they may be in use. Something like ChatLog was deprecated for years before it was removed. I think it might be smart to leave it deprecated for a couple of months.

+1 for "delete". Also Fund (which is basically a demo for Phortune).

Counter-diff: Keep the hackiness confined

The more I look at the code, the less I understand the comment about "just use getIsNewObject()".

Shouldn't have been. This is a support request, not a task.

Hi,
this should probably be a question in Ponder, not a task/bug report.
Bug reports require reproduction.

maybe

if ($this->getIsNewObject() || $xaction->getTransactionType == ...)

?
Then it only needs to be tested in the one case, and we can avoid code creeping from Differential here.

Do all messages require one-click unsubscribe?
No. One-click unsubscribe is required only for marketing and promotional messages. Transactional messages are excluded from this requirement. ...

In T15719#15276, @Dzahn wrote:

@phab1004:/srv/phab/phabricator/bin# ./mail volume

Killed

1. Would adding List-Unsubscribe: https://we.phorge.it/settings/panel/emailpreferences/ header be enough to solve this?

What issues did you run into when using ./bin/mail send-test?

## Contents

- is Phorge good for my Organization?
- differences between Phorge and GitLab, GitHub, Launchpad, Mantis, ...
- what's new in Phorge (that is not in Phabricator)
- practical workflows and pitfalls
- how to join the Phorge community
- how to propose code patches

I was able to trigger the "missing gd" warning (By uninstalling php*gd), so we're good there.
A bit puzzled about how you got the error if you already have it installed?

Values given in em units may produce unexpected results...

Thanks
also - need to run bin/celerity map before landing?

please make the title more descriptive of the actual change (what it's doing) - "improve usability" is very vague.
maybe "don't hide title in search" or something like that.

If it's only for a small number of such words, they should probably just be added to the blacklist remarkup.ignored-object-names - in fact, we should probably add S3 at least as a default; And probably find a way to expose this config option. Maybe a button on the Remarkup box that will help adding things to the blacklist?

mm, see this one: https://secure.phabricator.com/T5301#211340

Is the motivation only to allow not-magicking things like "S3" and "F1", or is there more?

Is that something we can improve in the settings page/docs - give better instructions on this setting?

Do we have a setup-warning about the gd extension being missing?

I've created R10 PhorgeIt Extension for this, with a little bit of content. I'll load it to the server shortly.

+lots for removing the words "storage containers" - projects are very much not "storage".
A better metaphor is "labels" or "index" (like in a printed book? Is that something young people know about?).

Also for Archived Projects, and maybe some other objects.
I'm not sure if there's a generic way to do this, or if each search-engine needs to be updated manually.