See discussion and reasons in https://secure.phabricator.com/T11833

In T15039#1358, @bekay wrote:

The clone repo modal could really use some copy buttons.

Preferably replacing the Read / Write Button.

So maybe this is just a matter of parsing that commit part "Depends-on:" since everything else seem already implemented to me. Partially related quiz in T15738

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

I'm trying to imagine a title that also involves the UX in general about accepting revisions, since it's also about the "Accept Revision" button, but my brain is not helping me right now in this

I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.

I think that D25359 is a nice example of a complete use case, where one Diff from one repo depends from another Diff from another repo.

I've explored a bit the codebase and this seems a desired non-feature.

Uh thanks! Feel free to increase the "Hours invested" counter in the Task description ihih

Ok, I got bored.

I think we have an implementation:

My plan is:

• If there's a commit information in the revision, use the author name and email from there. Not that this might not be the same as the revision's Author
• If there's no git commit - use author name from Author field, and make up email address (annonymos@example.com).

@avivey Yes I think this is what we need.
There is a caveat though:

@ton - this is what I have so far:

I have created T15559 with extra information, now that D25342 was closed and the issue behavior changed somewhat.

Feel free to elevate this as a Task, since it's a nice bug report

Unsure if tagging as Bug Reports

The workaround for me was to manually strip all of these lines:

yeah, typo. I'll fix it again...

ok, now I understand.

Thanks :) Silly question since I'm not native English: is there a repetition in "creating revision from revision from raw diff"?

I agree and that is why the general idea is: still showing your Diffs, but, showing the selected one (even if it's not yours). So it's just a +1 entry

I suspect just listing all open revisions would make using this page even worse - users will have to wade through a giant list.

In an early version I did not consider "do it only in create mode". Now I think the patch D25338 does what we imagine.

Here the follow-up:

Can I just propose a veeery small fix for this (it's one line, after all), and then create another one to modernize the workflow with that component? I'm not sure I will be able to do not destroy everything if I immediately try the modernization ihih

consider just replacing the selector with a modern AphrontFormTokenizerControl - that smart search features.

Marginally related to T15096

The task had a heavy dose of "describe a solution, not a problem", so I cleaned it up.

Hoping to receive more feedback from the original author (without closing as invalid) I keep open but with a cute Clarification Needed

Probably this is a good starting point to understand what to do:

More prior art: https://zuul-ci.org/docs/zuul/latest/gating.html#cross-project-testing

Arcanist internally generates a diff that includes a similar suggested parameter to account for the entire file contents being present in the resulting diff.