Uploading the patch that works on my computer now®

Thanks for this patch that unfortunately it's revealing even more weird legacy ghosts.

Ah...I may take another look (jmeador: Feel of course also very free to commandeer this back to you)

Ah sorry for maybe stepping on toes, and welcome back! :)

Seems @jmeador is AWOL thus updating per last comment

seems @jmeador is AWOL thus boldly commandeering

This makes me and probably other people mad lol

Thanks revi. Dear @dereckson probably your nice installation is still on the legacy Phabricator? (or a Phorge before 2023 Week 17, accordingly to wiki search results)

Cannot repro on current stable (rPd3c0a7edc3fc and rARC05abd055019c as of today). Tested on local installation.

Uh there's also phid_group_by_type($type) for extra readability and less code. Also maybe more modular for future things.

Hi @jmeador would you appreciate an help to update this?

See discussion and reasons in https://secure.phabricator.com/T11833

In T15039#1358, @bekay wrote:

The clone repo modal could really use some copy buttons.

Preferably replacing the Read / Write Button.

So maybe this is just a matter of parsing that commit part "Depends-on:" since everything else seem already implemented to me. Partially related quiz in T15738

can confirm, https://we.phorge.it/D25342?id=1111 does show an error for me in an incognito window.

Probably, something should "Attach" these files by default to that Diff, during the upload phase.

A workaround is to make all files as "Public". I fixed for example the diff D25079: Trigger: Add Sound "Coin" by setting the audio file F1271256 as public.

Hmm I’ve used mercurial and arcanist/Phab for years at my company and don’t believe we’ve ever run into this. Any idea what’s causing the presence of the BOM? We’ll apply a change to handle the UTF-8 bom but I am curious what may have caused it to show up. Is your hgrc configured in some way for this or maybe an environment variable?

I don't think we have a specific task for "general UI text improvements" - there's the UX project, but "improve UX" is an ongoing process, so I don't think a single parent task is a good match.

By the way, is there a task or project about UI text improvements that this task could be made part of? I am looking e.g. at the button in this very comment box saying "Set Sail for Adventure", which, while amusing, is also prone to cause confusion.

How about something like "Endorse"? That might remove the connotations of speaking for the project position that something like "approve" or "accept" may imply.

I'm trying to imagine a title that also involves the UX in general about accepting revisions, since it's also about the "Accept Revision" button, but my brain is not helping me right now in this

I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.

I think that D25359 is a nice example of a complete use case, where one Diff from one repo depends from another Diff from another repo.

I've explored a bit the codebase and this seems a desired non-feature.

Uh thanks! Feel free to increase the "Hours invested" counter in the Task description ihih

Ok, I got bored.

I think we have an implementation: