Page MenuHomePhorge

Allow comment authors to change their inline comment Status (Done / Not Done)
Open, LowPublic

Description

At the moment it seems that, when somebody reviews a line, adding an inline comment in Differential, then that person cannot change the Done/Not Done flag again. Note that, the author of the patch, instead, can.

This seems a bit counter-intuitive to me, since the author of the patch usually has lower-privileges than a reviewer, so it's strange that the patcher can change stuff made by the reviewer, but the reviewer cannot update their Done/Not Done flags.

So the striked yes is the proposed change:

ActionAuthor of PatchAuthor of Comment
Edit Status from own commentsYesNo yes
Edit Status from other commentsYesNo

Interesting context:

  • https://secure.phabricator.com/T9367 · Add "Done" link to an inline comment
  • https://secure.phabricator.com/T8573 · All reviewers should be allowed to mark a comment as done
    • so it seems this just misses comment authors
    • the idea is consistent with "Sometimes people just forget to mark comments as done."
    • the idea is consistent with "Sometimes a comment gets out of date, possibly because of a rebase/merge or a change in another part of the diff"
  • ...

Event Timeline

valerio.bozzolan triaged this task as Wishlist priority.
valerio.bozzolan created this object in space S1 Public.
valerio.bozzolan renamed this task from Allow more people to mark an inline comment as "Done" to Allow comment authors to change their inline comment Status (Done / Not Done).Jul 25 2023, 12:38
valerio.bozzolan updated the task description. (Show Details)
valerio.bozzolan raised the priority of this task from Wishlist to Low.Fri, Feb 21, 08:02

This makes me and probably other people mad lol