At the moment it seems that, when somebody reviews a line, adding an inline comment in Differential, then that person cannot change the Done/Not Done flag again. Note that, the author of the patch, instead, can.
This seems a bit counter-intuitive to me, since the author of the patch usually has lower-privileges than a reviewer, so it's strange that the patcher can change stuff made by the reviewer, but the reviewer cannot update their Done/Not Done flags.
So the striked yes is the proposed change:
Action | Author of Patch | Author of Comment |
---|---|---|
Edit Status from own comments | Yes | |
Edit Status from other comments | Yes | No |
Interesting context:
- https://secure.phabricator.com/T9367 · Add "Done" link to an inline comment
- https://secure.phabricator.com/T8573 · All reviewers should be allowed to mark a comment as done
- so it seems this just misses comment authors
- the idea is consistent with "Sometimes people just forget to mark comments as done."
- the idea is consistent with "Sometimes a comment gets out of date, possibly because of a rebase/merge or a change in another part of the diff"
- ...