To allow git am to accept patches produced using this, let ArcanistBundle produce the right headers.
Ref T15249.
Details
Details
- Reviewers
ton valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15249: Generate [From, Subject, Date] fields in download raw .diff URL to support "git am" and friends
See D25359.
Diff Detail
Diff Detail
- Repository
- rARC Arcanist
- Branch
- raw-diff-more-data
- Lint
Lint Passed - Unit
Tests Passed - Build Status
Buildable 693 Build 693: arc lint + arc unit
Event Timeline
| src/workflow/ArcanistExportWorkflow.php | ||
|---|---|---|
| 206 | This is not related, but I was already here. git config ... adds a newline to the output. | |
| src/workflow/ArcanistExportWorkflow.php | ||
|---|---|---|
| 206 | If the need is to remove a newline, note that trim() removes spaces | |
| src/workflow/ArcanistExportWorkflow.php | ||
|---|---|---|
| 206 | close enough - email shouldn't have any whitespace in it, afaik. | |
| src/workflow/ArcanistExportWorkflow.php | ||
|---|---|---|
| 206 | Oh sorry - I'm wrong! trim() as default removes that since always http://web.archive.org/web/20010215013717/https://www.php.net/manual/en/function.trim.php And now I have to fix some other trims in other projects... | |
Comment Actions
Thanks again \o/
Note for other people: it is normal that sometime the user's email is not exposed even after this change: for example it happens when uploading a patch from the web interface (since Phorge is nice and respects users' privacy and we do not publish their emails as default).
The problem is, Phorge is nice and may not expose the email as default, but the user cannot add this information later. This is not nice, and this can indeed be discussed to further improvement. For example, allowing users to explicitly mark some personal email addresses as public, and so, we could start exposing them from Differential. Or, adding an explicit "email" field to Differential - but I don't know.
I'm just saying that this is nice as-is. Thanks