Page MenuHomePhorge

Added a Mentions tab to the Differential Revision View
Needs ReviewPublic

Authored by Ekubischta on Wed, Feb 26, 23:06.

Details

Summary

This revision adds a Mentions tab to the revision between the History and Commits tabs

The tab functions exactly like the tab you see on a Maniphest task

The reason for this change is that when you have revisions that have lots of activity, or, lots of mentions in other places (including tasks, and other revisions) it is hard to see that list in a concise way

For discussion

  • Should we extend this to other objects? - And if so, do we need to make this reusable in some way?
    • I left the function name as newMentionsTab for consistency with Maniphest for now
  • Does the tab order matter or is between History and Commits just fine?

image.png (480×1 px, 26 KB)

Closes T16003

Test Plan

Made a revision, mentioned it, and saw mentions

Diff Detail

Repository
rP Phorge
Branch
T16003-Differential_Revision_Mentions_Tab
Lint
Lint Warnings
SeverityLocationCodeMessage
Warningsrc/applications/differential/controller/DifferentialRevisionViewController.php:570XHP25Spaces Inside Parentheses
Unit
Tests Passed
Build Status
Buildable 1748
Build 1748: arc lint + arc unit