Page MenuHomePhorge

`git format-patch` format not supported on differential web create form
Closed, InvalidPublic

Description

While arc handles logic for patches generated by git format-patch with 46fe94db9f8c, this is NOT the case if a patch is created through the web interface at /differential/diff/create/

The Git metadata in footer breaks the diff parser:

Unhandled Exception ("Exception")	
Diff Parse Exception: Expected a hunk header, like 'Index: /path/to/file.ext' (svn), 'Property changes on: /path/to/file.ext' (svn properties), 'commit 59bcc3ad6775562f845953cf01624225' (git show), 'diff --git' (git diff), '--- filename' (unified diff), or 'diff -r' (hg diff or patch).

             53   +   uid: 2038
             54   +
             55      pkuz:
             56        fullname: PK of UZ
             57        ssh_keys:
   >>>       58   -- 
             59   2.37.1 (Apple Git-137.1)
             60

Trail information

Initially reported to Nasqueron - https://devcentral.nasqueron.org/T2077

Event Timeline

Cannot repro on current stable (rPd3c0a7edc3fc and rARC05abd055019c as of today). Tested on local installation.

Based on the fact that devcentral.nasqueron.org displays pre-2023 Week 23 homepage on mobile, I think you need to update to latest stable or master and verify it still happens on 2025 codebase?

IMG_7421.png (2×1 px, 621 KB)

valerio.bozzolan subscribed.

Thanks revi. Dear @dereckson probably your nice installation is still on the legacy Phabricator? (or a Phorge before 2023 Week 17, accordingly to wiki search results)

We are available for help, but basically your installation may want to do this and embrace Phorge

https://we.phorge.it/w/installation_and_setup/update_from_phabricator/

Available for clarifications in chat or Ponder questions or whatever, but this probably is already fixed