`git format-patch` format not supported on differential web create form
Open, LowPublic
Actions

Assigned To

None

Authored By

	dereckson
	Oct 31 2024, 18:24

Description

While arc handles logic for patches generated by git format-patch with 46fe94db9f8c, this is NOT the case if a patch is created through the web interface at /differential/diff/create/

The Git metadata in footer breaks the diff parser:

Unhandled Exception ("Exception")	
Diff Parse Exception: Expected a hunk header, like 'Index: /path/to/file.ext' (svn), 'Property changes on: /path/to/file.ext' (svn properties), 'commit 59bcc3ad6775562f845953cf01624225' (git show), 'diff --git' (git diff), '--- filename' (unified diff), or 'diff -r' (hg diff or patch).

             53   +   uid: 2038
             54   +
             55      pkuz:
             56        fullname: PK of UZ
             57        ssh_keys:
   >>>       58   -- 
             59   2.37.1 (Apple Git-137.1)
             60

Trail information

Initially reported to Nasqueron - https://devcentral.nasqueron.org/T2077