GitHub/Facebook is already supported as a Login/Registration providers.

I think the purpose is to tell the IDE that the function receives a type and returns that exact type.

I don’t believe this style of doc annotation is used elsewhere. What’s the purpose of this?

Seems good

(Working on fixing it...)

Did my previous comment sufficiently elaborate that this is not a change in behavior? If the comment did not, please speak up before I may merge this. :) Thanks!

(I took the liberty to link the specific change in Git in the commit message)

(Stupid question :D sorry - clear now)

In D25575#16550, @valerio.bozzolan wrote:

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

In D25080#16549, @aklapper wrote:

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

Where I can document myself about undefined_magic_text? Undetected with grep 🤔

That's due to https://git.kernel.org/pub/scm/git/git.git/commit/revision.c?id=71a1e94821666909b7b2bd62a36244c601f8430e

I still think that the two Subscriber Rule value should be a list strings should for consistency be Add subscriber rule value should be a list respectively Remove subscriber rule value should be a list.

I've created D25575 for this case, and filed T15783 for the broader issue.

fix red color for removal (like in PhabricatorProjectTriggerRemoveProjectsRule)

follow code review - thanks

Probably my somewhat 10 cents at a broader level;

In D25573#16505, @aklapper wrote:

Thanks! Definitely way more correct :) Feel free to arc land

UI wise this seems to work as expected, and I think there's no way to move stuff on a workboard via Conduit. Just needs some smaller string adjustments.

Small capitalization nitpick, seems all other options use sentence case instead of title case:

git rebase master

Make lint happy

I'll keep the older version of git on until this is patched. One of the stakeholders of that repo can't be arsed to add params to the URL. Thanks for the alternative workaround though!

Thanks! Definitely way more correct :) Feel free to arc land

Done:

I wonder if xhpast can be ditched. Eg:
For linters, use something off-the-shelf such as phpcs (https://github.com/squizlabs/PHP_CodeSniffer)
For diviner parsing of PHP code, I look at the class documentation (eg https://we.phorge.it/book/libphutil/class/ArcanistConduitCallFuture/) and question as to whether this provides anyone with any benefit.

and I'm sorry that this is becoming so time expensive

I guess another question is whether to define an abstract public function getCommentFieldPlaceholderText() in parent PhabricatorEditEngine and then add to all and every child EditEngine a default public function getCommentFieldPlaceholderText($object_phid) { return '' };. Feels cleaner to me.

Ouch I see that receiving the engine was very complicated.

Abstract logic: Move application specific conditions to display a comment field placeholder text into the corresponding EditEngine of the object that the comment field is displayed in, by defining a public getCommentFieldPlaceholderText() function.

In D25546#15665, @valerio.bozzolan wrote:

I also don't get if in this part we have access to any thing related to Maniphest, ManiphestEditEngine or this kind of stuff, to just call $something->getCommentPanelPlaceholder() and have the business logic there in the specific application itself.

In T15047#1308, @speck wrote:

Sorry for the late reply.
The Diagrams extension (which just references the draw.io codebase) already has something like that in it.
You can use {DIAG1} in remarkup for showing Diagram 1 in e.g. a wiki document.
You can also import Mermaid diagrams in here.

A weird but... expandable, fast, easy possibility is introducing this syntax:

Also apologies for not testing this locally in the phab ui, I was far too confident in my TDD.

man I didn't even consider that you could actually have a valid project named #0dba11 ... maybe the syntax should be something different. #{00ffff} perhaps?

Did that Phactory: Hosting Projects Here

This script can be used to download the entire graph: