This doesn't necessarily mean we need to raise the minimum PHP version (T15047), but I'd like to allow Libphutil libs to use more modern features (even if we won't use them in core).
This should cover:
New syntax may include:
| rARC Arcanist | |||
| D25551 | rARCf6261dc614a7 Arc liberate: support traits | ||
I wonder if xhpast can be ditched. Eg:
For linters, use something off-the-shelf such as phpcs (https://github.com/squizlabs/PHP_CodeSniffer)
For diviner parsing of PHP code, I look at the class documentation (eg https://we.phorge.it/book/libphutil/class/ArcanistConduitCallFuture/) and question as to whether this provides anyone with any benefit.