Thanks. Tested this in a correct situation and also causing a crash putting an unset($nodes[$current_node]) in ../arcanist/src/utils/AbstractDirectedGraph.php to see the nice exception message

It's something to do with the priority - it works if the priority is 150.
Probably one of the other similar rules is interrupting (icon? Object? Maybe it thinks this is a mention of a project?)

Doesn't actually work for me either after arc patch:

...or Pharkdown :D

It's kind of a shame that remarkup wasn't named Pharkup.

Actually add the rule to the remarkup engine.

LOL I only ever tested the unit test case. I forgot to add the rule to PhabricatorMarkupEngine:

We don't create the links to page$line in most places as hrefs, so this shouldn't be an issue.

• Don't exist in Diffusion
• Do exist in Paste
• Don't exist in Differential

In D25505#14536, @avivey wrote:

Alternatively, maybe catch the existing exception and show a nice error message + the form?

+celerity map

If it's that easy

FTR I gave this last version another test locally, feeding an mbox file with no subject header (which is accepted now without complaints), and bugging input again (which prints a correct error message instead of misleadingly complaining about a missing subject line)

I do not understand why it does not work to me.

There's no easy way to do that...
The diviner flow loads code from a repository, creates "cache" files, and then loads them directly to DB. I'm not sure it's even reasonable to try to run it on a different workspace copy.

Go MoreMimeMailParserPeouw

Simplify logic (thanks Mukunda!)

You should be able to just arc land this now...

I'm guessing $ is used instead of # because (1) a user-agent might not send the # part to the server, and (2) the natural behavior of # ("scroll to this anchor") isn't what the intended behavior ("highlight these lines and scroll to the first one").

Ah, also adding a smalll meta "noindex" HTML tag on legacy file.php$123 pages and similar ones, would maybe help a little bit.

In T15670#15501, @avivey wrote:

Thinking more, I think we'd like to allow the robots to index latest version of the code - these days the big boys know how to handle that. Stopping them from crawling older versions is still important.

Anyway, I vote to revert the change - commit pages can have discussions in.

If it's that easy, then I'm both impressed and surprised it remained this way for so long. I'm actually not quite sure I understand the reasoning for not using # to begin with.

In D25558#16391, @avivey wrote:

(The images aren't public/attached, so I can't see them)

Are there mechanisms to re-gen the doc after we land changes? If not that might be something we should be able to do with harnormaster, and we can bring the docs back after something like that is set up to ensure they’re always updated

As a work-around, you can probably add ?offset=0 to the URL.

(The images aren't public/attached, so I can't see them)

Agree with last comment

I'm curious about the use-case for copying comments as well - I'm guessing that there's some extra data that's added in the comments?

Add pht to string

Fix linting issues

Remove comment cloning

In D25568#16354, @valerio.bozzolan wrote:

In this way, do we skip that column creating a column shift?

Maybe we need to promote that NULL to empty string

add minor comment - ready again - tested

I never use them, because there is no real method search. I think, we should be considering generating a documentation with a real php documention tool. But whatever we do: I think we can remove them in their current form.

introduce a nice applyExternalEffect() to change external things (the orginal file)

All of this should maybe go under "applyExternalEffects()"

All of this should maybe go under "applyExternalEffects()", but I can't find any doc that explains what should go there. Looks like external runs after all the internal and the object being saved, and before final. 🤷‍♂️

See also note in https://we.phorge.it/D25475#inline-3542 - looks like "creating a transformation" is done in many places.

In D25568#16354, @valerio.bozzolan wrote:

In this way, do we skip that column creating a column shift?

In this way, do we skip that column creating a column shift?

Address review feedback:

The change looks reasonable though I’m not familiar at this level of the database schema design

In T15670#16064, @valerio.bozzolan wrote:

A root problem is that highlighted line number(s) should be a # fragment really, to do not multiply pages exponentially.

I'll test this locally, I can't see any reason we shouldn't merge it.

@kat: I've added you to the Trusted Contributors project, so you can now land this change!

Traced the Flags in Revision back to its origin in https://secure.phabricator.com/T1557. I knew about this one - but I was 100% sure that the feature was lost when the SearchEngine classes were introduced.

Whops, typo "Seperate" in the title - sorry for not noticing