Updated differential_faq.diviner as per review.

The AphrontRequest::getStr() method is known to return null or a string and any other value will cause a nuclear implosion from phutil_nonempty_string() and we like that

Nice! Just few inline tips

While it could be nice to have this, in the meanwhile I think that having something minimal like D25434 would be nice

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

Cowsay documentation moved to Remarkup section
Links to Remarkup section added to Differential documentation

In D25434#12399, @valerio.bozzolan wrote:

lol

Just a question. Why under differential and not related to Remarkup?

Just a question. Why under differential and not related to Remarkup?

Nice catch

Hi all, can this be approved if no one has any objections? Dashboards simply can't be modified under PHP 8.1 without this. Thanks.

In theory this could be a two-liner: Changing the last character of the $prefix, and in PhabricatorCursorPagedPolicyAwareQuery.php

- $map[$field->getFieldKey()] = $field->getValueForStorage();
+ $map[$field->getModernFieldKey()] = $field->getValueForStorage();

In practice that leads to: Unhandled Exception ("PhutilTypeExtraParametersException") - Got unexpected parameters: customfield, customfield.index.table, customfield.index.key

Did some digging, and it looks like Segoe is not something we can use:

Here is the homepage feed after I created this task. Nothing indicates that there was a task creation, just a triage:

Content is not in something, rather it's licensed under.

This is now resolved.

Thanks @aklapper, feel free to edit the Task description according to your proposal.

Nice catch. I agree that we should allow to have texts like asd {{{ lol }}} whey without any nuclear implosion needed by design just because we are trying to give support to cowsay or figlet.

<tl;dr>: This is a mismatch between legacy field keys still used for paging, versus modern field keys.

Add back code which shouldn't be removed.

Fix linting warnings.

Shorten too long line

Simplify code with neat functions as proposed by Valerio

Public contents are in Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) and Apache 2.0 unless otherwise noted.

In T15322#11590, @valerio.bozzolan wrote:

This would also help Wikimedia volunteers to upload screenshots of Phorge to Wikimedia Commons, avoiding annoying deletion procedures for the lack of the license in the very same page etc.

Nuance has a "GitHub Repository: Import issues and pull requests from a GitHub repository" Source Type - it might already be doing something related?

LGTM! :D

hey, @ton - is this useful for you?

yeah, just default to https if it doesn't include a schema, and I think it should be fine in that regards.
There's probably already some method somewhere that looks at a uri and chooses HTTPFuture or HTTPSFuture based on the schema...

I'm guessing this would break existing configurations. (Or we could detect if the endpoint contains the schema and prepend https:// only if it doesn't - for backwards compatibility).

• rollback CSS change

Better now?

• integrate tips from reviewers