Page MenuHomePhorge
Feed All Stories

Aug 31 2023

valerio.bozzolan updated the name of F344028: Phorge home proposal.png from "Screenshot_2023_08_31_104248.png" to "Phorge home proposal.png".
Aug 31 2023, 08:43
avivey triaged T15630: Fix Fonts as High priority.
Aug 31 2023, 08:22
valerio.bozzolan added a comment to T15049: Segoe UI Symbol provides bad user experience.

Just to inform that maybe a sub-task bug report will be created soon. Related discussion: https://phabricator.wikimedia.org/T333885#9132176

Aug 31 2023, 08:08 · Fonts
valerio.bozzolan triaged T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out as Normal priority.
Aug 31 2023, 07:46 · Bug Reports, Differential
avivey added Q73: File Visibility (Answer 99).
Aug 31 2023, 07:07
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 31 2023, 06:44
valerio.bozzolan added a comment to D25420: Improving UX for ignoring timezone conflicts.

(I accepted but before landing please first review all not-done inline comments: https://we.phorge.it/differential/revision/inlines/25420/ and this comment: https://we.phorge.it/D25420#12264 )

Aug 31 2023, 05:13
valerio.bozzolan accepted D25420: Improving UX for ignoring timezone conflicts.

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

  • Instead of "You can ignore this conflict or adjust your profile setting to match your client", we should use the same order in the sentence as the options are shown to the user: "You can adjust your profile setting to match your client, or ignore this conflict."
  • The label for the checkbox should be just "Ignore Conflict", without the "Or" at the start.
  • When the "Ignore Conflict" checkbox is selected, the timezone dropdown should be disabled (and re-enabled if the checkbox is unmarked)
Aug 31 2023, 05:09

Aug 30 2023

waldyrious added a comment to D25413: Show a link to the Phorge homepage.

Yeah, that's nice! Though I'd replace the ! at the end with a :, and would remove the horizontal ruler (while keeping the new paragraph for the we.phorge.it link). This way it is clear that the last line is a continuation of the previous one; otherwise, it may not be immediately clear how one is supposed to "join the community".

Aug 30 2023, 18:46
waldyrious added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

maybe in the future we can have a CSS selector to be applied just to the "phorge/" pathname, in order to avoid mouse selection, and select just the command.

Aug 30 2023, 18:38
waldyrious abandoned D25426: Fix label of submit button in timezone conflict dialog.

See D25420 for a conflicting change...

Aug 30 2023, 18:32
waldyrious added a comment to D25420: Improving UX for ignoring timezone conflicts.

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

Aug 30 2023, 18:27
avivey closed D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:20
avivey committed rPaeab4efe17cf: Generate Diviner book for Javelin.
Generate Diviner book for Javelin
Aug 30 2023, 18:20
chris accepted D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:17
avivey requested review of D25429: Generate Diviner book for Javelin.
Aug 30 2023, 18:17
kfoster asked Q73: File Visibility.
Aug 30 2023, 17:56
valerio.bozzolan marked Q72: Add support for Cloudflare Turnstile (A Captcha alternative)? (Answer 97) as hidden.
Aug 30 2023, 16:25
avivey added a comment to D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.

Check out https://we.phorge.it/book/contrib/article/javascript_coding_standards/ and the Javeline docs here: https://github.com/phacility/javelin/tree/master/src/docs/concepts
(I'll try to render the Javeline guide here later).

Aug 30 2023, 14:24
valerio.bozzolan added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

Sorry, I mean this link:

Aug 30 2023, 14:21 · Bug Reports
valerio.bozzolan added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

I absolutely don't know what we are doing here since I don't know the supposed "Phabricator way" to interact with the DOM via JavaScript using its library.

Aug 30 2023, 14:20 · Bug Reports
roberto.urbani updated the test plan for D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:45
roberto.urbani requested review of D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44
roberto.urbani added a revision to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized: D25428: Fix the issue about persistent chat setting icon being clickable when the chat is collapsed.
Aug 30 2023, 12:44 · Bug Reports
valerio.bozzolan attached a referenced file: F274834: Comments deleted Before D25096.png.
Aug 30 2023, 10:20
valerio.bozzolan attached a referenced file: F274835: Comments deleted After D25096.png.
Aug 30 2023, 10:20
valerio.bozzolan edited the content of 2023 Week 32.
Aug 30 2023, 07:50
valerio.bozzolan added a comment to F343635: Phorge written on Wikipedian shirt.png.

Screenshot from:

Aug 30 2023, 07:43
valerio.bozzolan added a comment to Wikimania Hackathon 2023 Singapore.

We were able to push Phorge subliminal messages in an official Wikimedia video \o/

Aug 30 2023, 07:42
valerio.bozzolan updated the name of F343635: Phorge written on Wikipedian shirt.png from "Phorge written on Wikipedia shirt.png" to "Phorge written on Wikipedian shirt.png".
Aug 30 2023, 07:41
valerio.bozzolan updated the name of F343635: Phorge written on Wikipedian shirt.png from "Screenshot_2023_08_30_093752.png" to "Phorge written on Wikipedia shirt.png".
Aug 30 2023, 07:41
valerio.bozzolan added a comment to D25413: Show a link to the Phorge homepage.

Yeah thanks! Maybe we can somehow keep the footer, in order to have a link for people like me that just have their brain switched-off and just look at the bottom link. Also maybe we can simplify a little bit.

Aug 30 2023, 07:31
valerio.bozzolan added a revision to T15006: Re-brand Phorge: D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07 · Phorge
valerio.bozzolan updated the summary of D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07
valerio.bozzolan updated the summary of D25425: Remove mention of Phabricator in the Auth setup check.
Aug 30 2023, 07:07
valerio.bozzolan added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

Thanks for this patch. Yeah if I understand correctly, this should work:

Aug 30 2023, 07:06
valerio.bozzolan added a comment to D25427: Clarifying the operating system choices..

I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".

Aug 30 2023, 06:45 · Documentation
valerio.bozzolan added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 30 2023, 06:40
avivey added a comment to D25426: Fix label of submit button in timezone conflict dialog.

See D25420 for a conflicting change...

Aug 30 2023, 06:22
avivey added a comment to D25425: Remove mention of Phabricator in the Auth setup check.

ooh, check out D25349 for basically this exact use-case...

Aug 30 2023, 06:21

Aug 29 2023

Juest closed D25427: Clarifying the operating system choices..
Aug 29 2023, 23:15 · Documentation
Juest committed rP4c314a733c1d: Clarifying the operating system choices..
Clarifying the operating system choices.
Aug 29 2023, 23:15
chris accepted D25427: Clarifying the operating system choices..
Aug 29 2023, 22:49 · Documentation
Juest requested review of D25427: Clarifying the operating system choices..
Aug 29 2023, 22:30 · Documentation
waldyrious removed a reviewer for D25425: Remove mention of Phabricator in the Auth setup check: Blessed Committers.
Aug 29 2023, 21:33
waldyrious updated the summary of D25426: Fix label of submit button in timezone conflict dialog.
Aug 29 2023, 21:32
waldyrious requested review of D25426: Fix label of submit button in timezone conflict dialog.
Aug 29 2023, 21:32
waldyrious requested review of D25425: Remove mention of Phabricator in the Auth setup check.
Aug 29 2023, 21:18
waldyrious added a comment to D25413: Show a link to the Phorge homepage.

IMO the added text should be connected to the second sentence of the existing third paragraph, maybe as a separate paragraph. In fact I'd suggest re-grouping the paragraphs differently, to focus on a brief intro, info for users, and info for contributors. Perhaps something like this:

Aug 29 2023, 18:43
roberto.urbani added a comment to T15626: [Web] Persistent chat settings should not be clickable or visible when the chat is minimized.

@valerio.bozzolan I found the js section where with the listener for open/close the persistent chat. From there I can get element somehow (by ID I don't think it would be good, because it seems to be auto-generated (UQ3_0)) and remove the class "core-menu-item" and the invisible gear icon will no longer be clickable. If the chat is not minimized, we add the class back so we can see it and click it.

Aug 29 2023, 15:44 · Bug Reports
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 14:19
valerio.bozzolan added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 12:57
valerio.bozzolan updated the diff for D25420: Improving UX for ignoring timezone conflicts.

cosmetic whitespace changes

Aug 29 2023, 12:54
valerio.bozzolan resigned from D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 12:50
avivey accepted D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 12:49
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 12:33
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420:

Aug 29 2023, 12:27
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 08:45
avivey requested changes to D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 08:44
valerio.bozzolan added a comment to D25066: Workboard: Milestone Name easily editable (instead of surfing 3 pages).

I'm not a virus but a dolphin.png (466×640 px, 510 KB)

Aug 29 2023, 07:11
valerio.bozzolan updated the name of F343137: I'm not a virus but a dolphin.png from "image.png" to "I'm not a virus but a dolphin.png".
Aug 29 2023, 07:10
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 29 2023, 07:07
valerio.bozzolan awarded D25415: Make InterpreterBlockRule regex only match on valid interpreter names a Love token.
Aug 29 2023, 06:57

Aug 28 2023

valerio.bozzolan added a comment to D25415: Make InterpreterBlockRule regex only match on valid interpreter names.

This is very promising. Just added an inline comment

Aug 28 2023, 20:13
valerio.bozzolan retitled D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page from Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 28 2023, 19:58
valerio.bozzolan retitled D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser from Fix a PHP 8.1 deprecated use of strlen with a NULL argument
Aug 28 2023, 19:57
avivey added inline comments to D25420: Improving UX for ignoring timezone conflicts.
Aug 28 2023, 18:43
avivey added a comment to D25420: Improving UX for ignoring timezone conflicts.

if you check the checkbox, it will use the current setting timezone.

Aug 28 2023, 18:39
20after4 awarded T15583: Typeahead datasource query for repos should match substrings a Like token.
Aug 28 2023, 17:32 · Feature Requests, Diffusion
valerio.bozzolan attached a referenced file: F274834: Comments deleted Before D25096.png.
Aug 28 2023, 16:40
valerio.bozzolan attached a referenced file: F274835: Comments deleted After D25096.png.
Aug 28 2023, 16:39
valerio.bozzolan edited the content of Wikimania Hackathon 2023 Singapore.
Aug 28 2023, 16:39
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 28 2023, 15:46
roberto.urbani updated the summary of D25420: Improving UX for ignoring timezone conflicts.
Aug 28 2023, 15:38
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420: Updating D25420: fixed tests error

Aug 28 2023, 15:37
roberto.urbani updated the diff for D25420: Improving UX for ignoring timezone conflicts.

Updating D25420: Added a checkbox to ignore timezone conflict in Adjust Timezone dialog window. Using the checkbox instead of a button because this way it's possible to reuse the existing form. Also, i still didn't find a way to capture the additional button click event. This way, if you check the checkbox, it will use the current setting timezone.

Aug 28 2023, 15:20
valerio.bozzolan updated the task description for T15149: Fix middle-click, CTRL+click, right-click etc. on Typehead search results.
Aug 28 2023, 14:07 · Affects-Wikimedia, User-valerio.bozzolan, Typeahead
valerio.bozzolan added a project to T15627: Clicking on meme then cancel causes redirection to homepage and dialog does not disappear: UX.

This is very probably a recent regression since I cannot reproduce on Wikimedia Phabricator.

Aug 28 2023, 13:49 · UX, Bug Reports
valerio.bozzolan retitled D25421: Audit Feed: less verbose when the author is the committer from Audit: do not show same author twice in Feed
Aug 28 2023, 13:37
Sten accepted D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.

Looks good

Aug 28 2023, 13:36
Sten accepted D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.

Looks good to me.

Aug 28 2023, 13:33
valerio.bozzolan added a comment to T15627: Clicking on meme then cancel causes redirection to homepage and dialog does not disappear.

This happens also with the Upload File dialog

Aug 28 2023, 13:33 · UX, Bug Reports
valerio.bozzolan added a comment to T15627: Clicking on meme then cancel causes redirection to homepage and dialog does not disappear.

Ah! I can reproduce exactly in this comment!

Aug 28 2023, 13:33 · UX, Bug Reports
valerio.bozzolan updated the task description for T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx) .
Aug 28 2023, 13:27 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan claimed T15577: Show existing Hovercards from more places.
Aug 28 2023, 13:19 · UX, User-valerio.bozzolan
valerio.bozzolan requested review of D25424: Curtain: add Hovercard support.
Aug 28 2023, 13:19
valerio.bozzolan added a revision to T15577: Show existing Hovercards from more places: D25424: Curtain: add Hovercard support.
Aug 28 2023, 13:19 · UX, User-valerio.bozzolan
valerio.bozzolan updated the name of F342785: Curtain with Hovercard.png from "image.png" to "Curtain with Hovercard.png".
Aug 28 2023, 13:14
bob requested review of D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Aug 28 2023, 13:05
bob added a revision to T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit: D25423: Fix a PHP 8.1 deprecated use of strlen with a NULL argument in commit parser.
Aug 28 2023, 13:04 · PHP 8 support
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 13:01
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 13:01
bob added a revision to T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit: D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:48 · PHP 8 support
bob updated the summary of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:48
bob requested review of D25422: Fix a PHP 8.1 deprecated use of strlen with a NULL argument on commit page.
Aug 28 2023, 12:47
bob added a comment to T15628: PHP 8.1 "strlen(null)" exception when displaying a 'recent' subversion commit.

Finally, after additional tests, I guess these issue are not related (as related in T15629)

Aug 28 2023, 12:40 · PHP 8 support
bob created T15629: PHP 8.1 "strlen(null)" exception when importing a subversion commit.
Aug 28 2023, 12:39 · PHP 8 support
valerio.bozzolan moved T15528: Diffusion commit Feed: avoid to show the author twice (Authored by xxx) from Code Sprint Candidate to PingDeath 🌚 on the User-valerio.bozzolan board.
Aug 28 2023, 12:32 · UX, User-valerio.bozzolan, Diffusion
valerio.bozzolan updated the diff for D25421: Audit Feed: less verbose when the author is the committer.

consider more cases

Aug 28 2023, 12:30
valerio.bozzolan updated the summary of D25421: Audit Feed: less verbose when the author is the committer.
Aug 28 2023, 12:28