That's usually a sign that the Daemons are in some trouble. Go to the Daemons app and see their status and task status.

Maybe the milestone reordering feature could be behind an opt-in toggle? Personally I don't see any problem with that and I'm also not sure why milestones have to be strictly sequential in the first place. I found myself creating milestones accidentally out of sequence and the only way to "reorder" was renaming the milestones, which felt quite punishing.

I didn't know what happened, but today email notification is working properly without any changes. {F195188}
Might be just a hiccup 😃

In D25037#1857, @avivey wrote:

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

In D25054#1871, @avivey wrote:

The change should also include updating the installation instructions, and a ticket.

@Matthew the arcanist herald rule needs to be set to trigger when both conditions are met - currently even if a change is accepted only a member of Releasers can land the change because it will trigger for anyone who isn’t a member of Releasers. We want it to trigger if it both hasn’t been reviewed and the user isn’t a member of Releasers.

For completeness: The security breaches mentioned in the security guidance task are all about exposing an existing file that the attacker has new view access to; This flow is only relevant to explicitly uploading a new file, so it doesn't have the same security implications.

The change should also include updating the installation instructions, and a ticket.

https://secure.phabricator.com/T9782 suggests it should be using the "custom fields" interface and eventually fizzles out.

Rebased and run unit tests again

(On a broader theme, this code should probably move into rP, right? Is there any use-case for arcanist directly making calls to 3rd party services?)

running celerity map should just fix it. I'll take a look.

I'm good with this, but we have a policy of "no landed diffs w/o tickets", so please create one before landing.

We should connect this script (scripts/celerity/*.php) into bin/celerity.

In T15105#3252, @tiguchi wrote:

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

I just submitted a patch and ran into issues with running unit tests. It seems like the tests expect me to set up a MySQL database. I submitted the patch with arc diff --nounit if that's OK with you

The harbormaster has passed and you have properly fixed the bug.

In T15105#3239, @Matthew wrote:

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

Would you be willing to create a revision so we can put that fix into upstream? If you're not sure how, or need some help, feel free to ping me!

Did we ever find out more about the hosting situation for phorge.it?

If the users want to use milestones instead of subprojects, can they not change the language settings to Pirate English or something and go from there?

In T15105#3233, @tiguchi wrote:

As a bandaid I patched the extractFilePHIDs method in PholioImageFileTransaction.php by adding a nested foreach loop as follows:

foreach ($new_phids as $phids) {
  foreach ($phids as $phid) {
    $file_phids[] = $editor->loadPholioImage($object, $phid)
      ->getFilePHID();
  }
}

This fixes the problem on our installation for now, but I would like to avoid having to manage any local changes

In addition to the above, it seems that commit d017f3f21021 is what broke this. And adjustTransactionValues is what changes the xaction from

Array
(
    [+] => Array
        (
            [0] => PHID-PIMG-m5pqg3eec46uvzw6uynm
        )

Small update: I just migrated our Phabricator installation to Phorge following the instructions in Update From Phabricator. The migration worked, but we still cannot upload new mockups.