Page MenuHomePhorge

Herald rule changes for release
Open, Needs TriagePublic

Description

There are two changes that need to be made to the Herald rules on this install.

  1. H7 Guard Phorge Repo with Blessed Committers blocked a direct push against rP, however; H8 Guard Arcanist Repo with Blessed Committers did not block a direct push against rARC. I should have been blocked on both.
  2. Both these rules need to be adjusted to allow for releases. The current release method is to push a commit against the stable branch, which should be rejected for users without permission to cut a release. Could we perhaps allow for specific pushes to specific branches if a user is part of a specific project or has a specific badge?

Event Timeline

@Matthew the arcanist herald rule needs to be set to trigger when both conditions are met - currently even if a change is accepted only a member of Releasers can land the change because it will trigger for anyone who isn’t a member of Releasers. We want it to trigger if it both hasn’t been reviewed and the user isn’t a member of Releasers.