This would be useful for discussions about design, specifically I wished for this feature while reviewing D25491: Improve contrast of Links in Dark Mode

Yeah, I don't like the diviner page.
For other included 3rd parties, we often put a license file right next to the asset:

• https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/font/lato/LICENSE.txt
• https://we.phorge.it/source/phorge/browse/master/webroot/rsrc/externals/d3/LICENSE
• https://we.phorge.it/source/phorge/browse/master/externals/mimemailparser/LICENSE
• and, https://we.phorge.it/source/phorge/browse/master/externals/octicons/LICENSE which is not next to the actual content.

In D25491#15484, @20after4 wrote:

In D25491#15482, @Iniquity wrote:

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

I actually think a darker background and lighter link color would be good. Maybe not quite as light as #accadf, perhaps #46B2FF or so

Volkan 🌋 ural

In D25079#15507, @valerio.bozzolan wrote:

https://we.phorge.it/T15178#4880

I'm also unsure and I would agree if somebody suggests to omit the Diviner page. Relevant discussion also from @avivey

I guess I'm fine with adding that mp3 file.
I am personally not convinced by the creation of src/docs/flavor/project_credits.diviner: I've seen way too many "let's create some list, with best intentions, and at some point unfortunately forget about updating it" examples in FOSS projects. Every added line in software projects creates additional maintenance costs (and in some cases bitrot); human resources are in theory unlimited and in reality rather sparse.
Credits could go into the git commit message, maybe?

It's the anniversary of this super-important killer feature 💌

In T15719#15304, @Tgr wrote:

Given how it's displayed on the Gmail UI, IMO unsubscribing from all emails or at least all emails of the given type (e.g. all Maniphest emails if it's a Maniphest notification) is the only thing that makes sense. If I mark an email as spam, and then use the unsubscribe option instead, I would not expect to continue getting identical email from all the other tasks.
No idea how (or if) other email clients handle the header, though.

This was both harder and easier then I expected. I got to crash the IDE and hard-code a bunch of stuff, but this actually works. Didn't even start on the Edges implementation yet - I'm directly using the Flags table.

See discussion and reasons in https://secure.phabricator.com/T11833

In D25491#15482, @Iniquity wrote:

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

The only progress I've made is to think through the implementation but I haven't actually started coding on it. It is sort of high on my wish list so I may get to it soon.

The word solution would solve it from the expecting side, you are right. Here in my company the search is used frequently and only as a plain text search. So we have to escape the special regex signs time and again. Just would be interested if this is seen as an issue by others who uses the feature.

We can probably add a checkbox, and some nicer handling for the exception. Or possibly, just adding the word "regex" might solve this from the "user expectation" side.

Thanks for the clarification. I still think we should tackle the exception.

The word "pattern" was meant to imply "regex pattern".
Specifically - the ability to search for a regex is much more useful then a plain-text only search (and costs us basically nothing).

Thanks, it works

In T15728#15768, @valerio.bozzolan wrote:

I tried to understand the situation. Thanks.

In your opinion: on the repo view (with clone buttons) is it really important to link to the other similar "reduced" view (without clone buttons)?

I tried to understand the situation. Thanks.

Ok, see here: https://we.phorge.it/book/phorge/article/configuring_outbound_email/#outbound-quot-from-quot-and-quot

• I have setup cluster.mailers using smtp type (phorge-mailer@gmail.com (example only))
• those messages are receive in phorge-mailer@gmail.com from google mailer, informing that noreply@phorge.domain.com is not reachable so it bounce.
• I assume, it happened because phorge send outbound email:
  • using noreply@phorge.domain.com as "To" address
  • "cc" address to recipients
  • "From" with format "Username (Fullname) <phorge-mailer@gmail.com>"
• Is it possible to disable or change "To" address other than noreply@phorge.domain.com, because I didn't setup phorge.domain.com to receive email.

btw, for the "search" use-case I'm describing, I'm imagining something like a Function on Users/project, so I can search, for example "Tasks that are assigned to users which I flagged with a green flag" or "Tasks that have a tag that I flagged with a blue flag".
And also, "Revisions that I flagged with any flag".

I looked into this again.

Hello! Are you sure changing the links color is a good idea? Perhaps we should just make the background darker?

Wiki volkankaos

Just asking for a friend: Is there some progress on this?

Maybe this could be integrated in the Diagrams extension...? I mean: the entire infrastructure is there - you just have to decide, what lib you wanne use when creating a new diagram. @mturdus What do you think about this?

It would be a pleasure to receive a patch from you :) The file should be this one:

Maybe this is wild, but: should we consider removing the compiled xhpast.exe file from the repository, and host is externally?
I think it's only used for working on PHP on Windows; The equivalent xhpast isn't included, presumably because compiling stuff on Windows is harder.
My argument for this is that the normal way to install arcanist is git clone, which downloads all the history (and 95% of users won't need this particular file).

Passed a week. Nobody commented. I blindly trust you in this field :3 Approve.

In T15673#15587, @valerio.bozzolan wrote:

TRUST ME - YOU DON'T WANT TO LISTEN MY ENGLISH :D :D

Btw now the video is here :D :D AGAIN SORRY PHORGE FOR MY MISTAKES <3 <3

https://video.fosdem.org/2024/h2215/fosdem-2024-3610-unpack-phabricator-welcome-phorge-forking-the-opinionated-open-source-project-manager.av1.webm

• Making @valerio.bozzolan happy

Premising that I've already accepted I noticed also this minor possible thing:

Lovely thanks :)

I really have struggled to find any device in our company that can't do await/async. I strongly bevlieve it is a non issue. Let us land this thing now and see if we get any feedback of an error.

• Changes the order of the variables and function calls

• Extends select behavior and only select content on first click

The ".then()" part is pure hackness; The async/await is the sane way to do async programming.

In D25536#15448, @valerio.bozzolan wrote:

Again, non-blocking opinion:

Are we aware that the "async" keyword (that was never used in Phorge) may just cause a crash by syntax error (almost-immediately even without clicking?) by that kind of browsers, so, breaking the page, just because we want to provide a copy function and we want to avoid .then()?

I think we can introduce breaking changes, but it's strange to do that, now, with this minor feature.

If we are aware of this minor risk, indeed let's land.

Again, non-blocking opinion:

In D25536#15446, @valerio.bozzolan wrote:

Additional non-blocking thing:

Maybe should be copy(text) with var data defined outside

Bonus point: copy() not defined during every call of JX.Stratcom.listen, but outside (?)

Additional non-blocking thing:

In D25536#15437, @valerio.bozzolan wrote:

Yes, we can avoid async.

So, this is just a tip, to avoid async and also to have everything a little more modular for no reason:

1. remove async from copy()
2. rename copy() to copyWithoutFeedback() and have the function that always return a Promise
   • so copyWithoutFeedback() has return navigator.clipboard.writeText(text); to always return a Promise
   • so copyWithoutFeedback() can use copyWithFeedback() but after that it return Promise.resolve(true) to always return a Promise
   • so copyWithoutFeedback() can fail with just return Promise.reject() to always return a Promise
3. so we can create the function with feedback, copyWithFeedback(), that just calls the previous one, so, copyWithoutFeedback().then(function() { show_success_message() } ); with also a chained .fail( function() { show_error_message(); } ) or something similar

• Updates map