Paths

Table of Contentst

Fix an instance of `strlen(null)`
ClosedPublic
Actions

Authored by avivey on Feb 23 2024, 11:29.

Tags

None

Referenced Files

	F3501700: D25539.1744795488.diff
	Tue, Apr 15, 09:24

	F3377470: D25539.1744340771.diff
	Thu, Apr 10, 03:06

	F3371879: D25539.1744246626.diff
	Wed, Apr 9, 00:57

	F3371643: D25539.1744244422.diff
	Wed, Apr 9, 00:20

	F3338713: D25539.1743608335.diff
	Tue, Apr 1, 15:38

	F3334595: D25539.1743551666.diff
	Mon, Mar 31, 23:54

	F3333936: D25539.1743541729.diff
	Mon, Mar 31, 21:08

	F3327514: D25539.1743440645.diff
	Sun, Mar 30, 17:04

Subscribers

Details

Reviewers

bekay
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4

Commits

rP8667ed45fada: Fix an instance of `strlen(null)`

Summary

Ref Q112, ref T15064.

Test Plan

Enter the text [[hello]] in a remarkup field - without this change, it causes a deprecation warning in the log.

This doesn't happen if the content looks like a valid URL - this is the "Wiki Link" syntax.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Feb 23 2024, 11:29

Owners added a reviewer: O1: Blessed Committers.Feb 23 2024, 11:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 23 2024, 11:29

avivey requested review of this revision.Feb 23 2024, 11:29

Harbormaster completed remote builds in B1070: Diff 1710.Feb 23 2024, 11:29

avivey mentioned this in Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 (Answer 144).Feb 23 2024, 11:30

avivey added inline comments.Feb 23 2024, 11:32

src/applications/phriction/markup/PhrictionRemarkupRule.php
75–80	I'm pretty much guessing that this is the only place `explicitName` can be created. `$name` is extracted from a regexp inline 19.

valerio.bozzolan accepted this revision.Feb 23 2024, 13:14

This revision is now accepted and ready to land.Feb 23 2024, 13:14

Closed by commit rP8667ed45fada: Fix an instance of `strlen(null)`. · Explain WhyFeb 23 2024, 15:06

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rP8667ed45fada: Fix an instance of `strlen(null)`.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

phriction/

markup/

PhrictionRemarkupRule.php

2 lines

O1: Blessed Committers

Diff 1712

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Fix an instance of `strlen(null)`ClosedPublicActions