Paths

Table of Contentst

Fix an instance of `strlen(null)`
ClosedPublic
Actions

Authored by avivey on Feb 23 2024, 11:29.

Tags

None

Referenced Files

	F3210475: D25539.1741442477.diff
	Fri, Mar 7, 14:01

	F3001455: D25539.1740442146.diff
	Mon, Feb 24, 00:09

	F3001453: D25539.1740442142.diff
	Mon, Feb 24, 00:09

	F2996611: D25539.1740382382.diff
	Sun, Feb 23, 07:33

	F2994504: D25539.1740312422.diff
	Sat, Feb 22, 12:07

	F2993560: D25539.1740287823.diff
	Sat, Feb 22, 05:17

	F2993559: D25539.1740287821.diff
	Sat, Feb 22, 05:17

	F2987205: D25539.1740110758.diff
	Thu, Feb 20, 04:05

Subscribers

Details

Reviewers

bekay
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4

Commits

rP8667ed45fada: Fix an instance of `strlen(null)`

Summary

Ref Q112, ref T15064.

Test Plan

Enter the text [[hello]] in a remarkup field - without this change, it causes a deprecation warning in the log.

This doesn't happen if the content looks like a valid URL - this is the "Wiki Link" syntax.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

avivey created this revision.Feb 23 2024, 11:29

Owners added a reviewer: O1: Blessed Committers.Feb 23 2024, 11:29

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptFeb 23 2024, 11:29

avivey requested review of this revision.Feb 23 2024, 11:29

Harbormaster completed remote builds in B1070: Diff 1710.Feb 23 2024, 11:29

avivey mentioned this in Q112: Deprecation Notice from PhrictionRemarkupRule.php:194 (Answer 144).Feb 23 2024, 11:30

avivey added inline comments.Feb 23 2024, 11:32

src/applications/phriction/markup/PhrictionRemarkupRule.php
75–80	I'm pretty much guessing that this is the only place `explicitName` can be created. `$name` is extracted from a regexp inline 19.

valerio.bozzolan accepted this revision.Feb 23 2024, 13:14

This revision is now accepted and ready to land.Feb 23 2024, 13:14

Closed by commit rP8667ed45fada: Fix an instance of `strlen(null)`. · Explain WhyFeb 23 2024, 15:06

This revision was automatically updated to reflect the committed changes.

avivey added a commit: rP8667ed45fada: Fix an instance of `strlen(null)`.

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

phriction/

markup/

PhrictionRemarkupRule.php

2 lines

O1: Blessed Committers

Diff 1712

View Options

src/applications/phriction/markup/PhrictionRemarkupRule.php

Fix an instance of `strlen(null)`ClosedPublicActions