Page MenuHomePhorge
Feed All Stories

Dec 10 2023

valerio.bozzolan edited the content of 2023 Week 32.
Dec 10 2023, 19:58
valerio.bozzolan added a comment to T15673: Phorge participation at FOSDEM 2024.

I'm quite sure that somebody of you will join FOSDEM. In case, please join this talk as presenter :)

Dec 10 2023, 19:49 · Blessed Communicators, Phorge
Rinalusi44 added a comment to D25466: Improve command line prompts in setup issue pages.
Dec 10 2023, 17:40 · Config, UX
valerio.bozzolan closed T15577: Show existing Hovercards from more places as Resolved by committing rP2295bcda14e7: Curtain: add Hovercard support.
Dec 10 2023, 15:55 · UX, User-valerio.bozzolan
valerio.bozzolan closed D25424: Curtain: add Hovercard support.
Dec 10 2023, 15:55
valerio.bozzolan committed rP2295bcda14e7: Curtain: add Hovercard support.
Curtain: add Hovercard support
Dec 10 2023, 15:55
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).

1b. Did you restart FastCGI after updating the code?

Dec 10 2023, 14:56
avivey closed Q99: permission to report a bug as resolved.
Dec 10 2023, 14:47
avivey added Q99: permission to report a bug (Answer 125).
Dec 10 2023, 14:46
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
  1. Yes, you should have D25387 - which makes it very strange that you're getting an exception.
  2. That's the trace, yes.
  3. I've added you to Trusted Contributors, so you can file bugs in maniphest, etc.
Dec 10 2023, 14:46
avivey added a member for Trusted Contributors: adrelanos.
Dec 10 2023, 14:46
adrelanos asked Q99: permission to report a bug.
Dec 10 2023, 13:39
speck added inline comments to D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 01:48
aklapper requested review of D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 00:00
aklapper added a revision to T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured: D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 00:00 · PHP 8 support

Dec 9 2023

speck added a comment to T15645: Implement "Locate File" input in Browse view.

I’ve been meaning to investigate this. It also has thrown me that it’s not available where you expect it. I do suspect @valerio.bozzolan is right

Dec 9 2023, 23:59 · Diffusion
speck awarded T15645: Implement "Locate File" input in Browse view a Like token.
Dec 9 2023, 23:57 · Diffusion
aklapper updated the task description for T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured.
Dec 9 2023, 23:50 · PHP 8 support
aklapper created T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured.
Dec 9 2023, 23:50 · PHP 8 support
avivey marked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123) as hidden.
Dec 9 2023, 08:46
avivey accepted D25424: Curtain: add Hovercard support.
Dec 9 2023, 08:44

Dec 8 2023

valerio.bozzolan added a comment to T15645: Implement "Locate File" input in Browse view.

I wonder if under the hood this means "Add branch support to Locate File"

Dec 8 2023, 20:01 · Diffusion
valerio.bozzolan updated the task description for T15577: Show existing Hovercards from more places.
Dec 8 2023, 19:58 · UX, User-valerio.bozzolan
avivey renamed 2023 week 49 from 2023.49 RC to 2023 week 49 RC.
Dec 8 2023, 17:38
avivey edited the content of Change Log.
Dec 8 2023, 17:38
avivey closed T15554: Handling PHP deprecations: convert to Setup Issues as Resolved.

Unless something broke, this task is now complete.

Dec 8 2023, 17:37 · Phorge
avivey renamed 2023 week 49 from Next Up to 2023.49 RC.
Dec 8 2023, 17:36
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Dec 8 2023, 16:05
avivey created T15690: PhutilErrorHandler - add try/catch around `call_user_func`.
Dec 8 2023, 16:04
avivey closed D25440: Show Deprecation Warnings as Setup Warnings.
Dec 8 2023, 15:56
avivey committed rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings.
Show Deprecation Warnings as Setup Warnings
Dec 8 2023, 15:56
avivey created T15689: built in exception display is missing top line.
Dec 8 2023, 15:54 · Phorge Development Tools
avivey edited the content of Report Warnings.
Dec 8 2023, 15:42
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • add PHP version
  • rebase
Dec 8 2023, 15:41
bekay claimed T15645: Implement "Locate File" input in Browse view.

Well, no opinions from the team. I still think this should be implemented... 😁

Dec 8 2023, 13:27 · Diffusion
deric updated the answer details for Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 124).
Dec 8 2023, 10:15
deric added a comment to Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).

I'm trying debug mode

./bin/phd debug PhabricatorTaskmasterDaemon
Dec 8 2023, 09:59
deric added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 124).
Dec 8 2023, 08:46
avivey added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).
Dec 8 2023, 08:36
deric updated the question details for Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker.
Dec 8 2023, 08:17
soloturn added a comment to T15100: [Feature request] Option to measure WIP limits based on card count instead of points, to more closely adhere to Kanban standards..

there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Dec 8 2023, 08:17 · Feature Requests, Maniphest, Discussion Needed, Affects-Wikimedia, Workboard
deric asked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker.
Dec 8 2023, 08:14
pppery added a comment to T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.

Also related: https://phabricator.wikimedia.org/T266966

Dec 8 2023, 06:06

Dec 7 2023

waldyrious closed D25466: Improve command line prompts in setup issue pages.
Dec 7 2023, 16:22 · Config, UX
waldyrious committed rPc49eeb235ea0: Improve command line prompts in setup issue pages.
Improve command line prompts in setup issue pages
Dec 7 2023, 16:22
valerio.bozzolan added a comment to D25466: Improve command line prompts in setup issue pages.

We may want to expand the Test Plan to mention additional tips to help newcomers in breaking their installation.

Dec 7 2023, 11:59 · Config, UX
valerio.bozzolan updated the test plan for D25466: Improve command line prompts in setup issue pages.
Dec 7 2023, 11:55 · Config, UX
valerio.bozzolan accepted D25466: Improve command line prompts in setup issue pages.

I love it, thanks.

Dec 7 2023, 11:54 · Config, UX
valerio.bozzolan updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 7 2023, 10:33 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan added a parent task for T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 7 2023, 10:32
valerio.bozzolan added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 7 2023, 10:32 · Discussion Needed, Affects-Wikimedia
speck added a comment to D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.

It might be safer to do a null check with the strlen check in case the value isn’t a string.

Dec 7 2023, 00:06

Dec 6 2023

aklapper added a comment to D25493: Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested.

Note that I did *not* test this locally yet; just putting it here so it does not get lost (again)

Dec 6 2023, 22:19
aklapper requested review of D25493: Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 6 2023, 22:18
aklapper added a revision to T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested: D25493: Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 6 2023, 22:18
aklapper updated the diff for D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

Still WIP, was just checking that nothing explodes locally (yet)

Dec 6 2023, 22:07
aklapper created T15688: "Undefined index: PHID-PROJ-***" in project.search API when project_customfieldstorage table has additional fields not requested.
Dec 6 2023, 22:03
valerio.bozzolan accepted D25491: Improve contrast of Links in Dark Mode.

Tested, thanks! no nuclear implosions and I like it. I also think that "accadf" is more readable than before :^) please wait some days before landing to eventually attract additional testers.

Dec 6 2023, 19:36
valerio.bozzolan updated the diff for D25491: Improve contrast of Links in Dark Mode.

arc lint

Dec 6 2023, 19:36
aklapper closed T15686: Include 'published' date in Phame atom feeds, a subtask of T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge, as Resolved.
Dec 6 2023, 19:34 · Discussion Needed, Affects-Wikimedia
aklapper closed T15686: Include 'published' date in Phame atom feeds as Resolved by committing rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds.
Dec 6 2023, 19:34 · Affects-Wikimedia, Feature Requests
aklapper closed D25490: Include 'published' date of posts in Phame Atom feeds.
Dec 6 2023, 19:34
aklapper committed rP6c8329fb6614: Include 'published' date of posts in Phame Atom feeds (authored by 20after4).
Include 'published' date of posts in Phame Atom feeds
Dec 6 2023, 19:34
aklapper updated the diff for D25490: Include 'published' date of posts in Phame Atom feeds.

git commit --amend --author="Mukunda Modell"

Dec 6 2023, 19:33
valerio.bozzolan added a revision to T15056: Improve Dark Mode: D25491: Improve contrast of Links in Dark Mode.
Dec 6 2023, 19:33 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan retitled D25491: Improve contrast of Links in Dark Mode from Links in dark theme have low contrast (T15056)
Dec 6 2023, 19:33
valerio.bozzolan updated the name of F416077: Links After.png from "image.png" to "Links After.png".
Dec 6 2023, 19:28
valerio.bozzolan updated the name of F416075: Links Before.png from "image.png" to "Links Before.png".
Dec 6 2023, 19:27
aklapper requested review of D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Dec 6 2023, 19:24
aklapper added a revision to T15687: PHP 8.1 "strlen(null)" exception when custom select field configured: D25492: Fix PHP 8.1 "strlen(null)" exception when custom select field configured.
Dec 6 2023, 19:24 · PHP 8 support
aklapper created T15687: PHP 8.1 "strlen(null)" exception when custom select field configured.
Dec 6 2023, 19:24 · PHP 8 support
aklapper added a comment to D25489: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom int field configured.

Urgh, indeed not the brightest proposed patch (though it worked locally).
Also need to rework/expand patch because there are several more places in this very file to fix.
More stacktraces triggered by going to http://phorge.localhost/maniphest/ :

Dec 6 2023, 18:49
aklapper closed T15684: PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3, as Resolved.
Dec 6 2023, 18:33 · PHP 8 support
aklapper closed T15684: PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured as Resolved by committing rP5ddca7da55e3: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Dec 6 2023, 18:33 · PHP 8 support
aklapper closed D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.
Dec 6 2023, 18:33
aklapper committed rP5ddca7da55e3: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest….
Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest…
Dec 6 2023, 18:33
aklapper updated the diff for D25488: Fix PHP 8.1 "strlen(null)" exception rendering dashboard panel with latest tasks when custom text field configured.

Also fix line 14

Dec 6 2023, 18:31
deric updated the summary of D25491: Improve contrast of Links in Dark Mode.
Dec 6 2023, 16:41
adrelanos updated the answer details for Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
Dec 6 2023, 16:41
adrelanos added Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
Dec 6 2023, 16:40
deric added Q97: Unable to submit patch via arc diff (Answer 121).
Dec 6 2023, 16:35
deric requested review of D25491: Improve contrast of Links in Dark Mode.
Dec 6 2023, 16:30
avivey updated the answer details for Q96: Support for FIDO2-backed SSH keys (Answer 120).
Dec 6 2023, 16:10
avivey added Q96: Support for FIDO2-backed SSH keys (Answer 120).
Dec 6 2023, 16:01
avivey awarded Q96: Support for FIDO2-backed SSH keys a Orange Medal token.
Dec 6 2023, 15:55
matmarex closed T15682: Different monospace fonts for inline code snippets and block code snippets as Resolved.
Dec 6 2023, 15:51 · Phorge
matmarex closed D25486: Use user's preferred font for inline code snippets too.
Dec 6 2023, 15:51
matmarex committed rPc8a927006067: Use user's preferred font for inline code snippets too.
Use user's preferred font for inline code snippets too
Dec 6 2023, 15:51
avivey added Q97: Unable to submit patch via arc diff (Answer 119).
Dec 6 2023, 15:50
waldyrious closed D25485: CSS adjustments to Conpherence.
Dec 6 2023, 15:36 · Conpherence
waldyrious committed rPe59702569f8e: CSS adjustments to Conpherence.
CSS adjustments to Conpherence
Dec 6 2023, 15:36
matmarex added inline comments to D25305: Workboard: have thin scrollbars.
Dec 6 2023, 15:35
matmarex changed the visibility for F337632: image.png.
Dec 6 2023, 15:34
waldyrious added a comment to D25485: CSS adjustments to Conpherence.

Thanks both! I'll land this, then.

Dec 6 2023, 15:32 · Conpherence
deric asked Q97: Unable to submit patch via arc diff.
Dec 6 2023, 15:24 · Arcanist
l2dy closed Q80: Bug: passing null to strlen in readLocalArcConfig as resolved.
Dec 6 2023, 14:24 · Arcanist
antonia asked Q96: Support for FIDO2-backed SSH keys.
Dec 6 2023, 13:48
valerio.bozzolan added inline comments to D25305: Workboard: have thin scrollbars.
Dec 6 2023, 08:28
avivey added Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 118).
Dec 6 2023, 08:21
valerio.bozzolan updated the answer details for Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 117).
Dec 6 2023, 08:21