Page MenuHomePhorge

Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested
ClosedPublic

Authored by aklapper on Dec 6 2023, 22:18.
Tags
None
Referenced Files
Unknown Object (File)
Tue, May 7, 22:32
Unknown Object (File)
Sat, May 4, 12:31
Unknown Object (File)
Thu, May 2, 04:54
Unknown Object (File)
Wed, May 1, 12:15
Unknown Object (File)
Sat, Apr 27, 16:48
Unknown Object (File)
Sat, Apr 27, 16:48
Unknown Object (File)
Sat, Apr 27, 16:48
Unknown Object (File)
Sat, Apr 27, 10:22

Details

Summary

Do not trigger an "Undefined index" error in PhabricatorCustomFieldStorage when calling the project.search Conduit API without passing search parameters when the local project_customfieldstorage table has additional fields configured not requested in the API call.

Closes T15688

Test Plan

See above; curl -k -s -X GET http://phorge.localhost/api/project.search?api.token=api-xxxxxxxxxxxx | jq -r for comparison

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

aklapper requested review of this revision.Dec 6 2023, 22:18

Note that I did *not* test this locally yet; just putting it here so it does not get lost (again)

20after4 subscribed.

Since this was vetted by epriestley and previously by myself as well. I think that it exceeded the minimum standard for code review before it landed here.

This revision is now accepted and ready to land.Dec 14 2023, 17:09