Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

In D25488#14099, @aklapper wrote:

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

Tested. No nuclear implosions :) Thanks!

If the patch was written by 20after4 we can probably set git commit --amend --author="Mukunda Modell". Can I help in this?

but very unlikely anyone would ever make the effort, with MySQL (and compatibles) being so easy to obtain.

Good catch. I don’t think it would cause an implosion but might result in not applying constraints when it should

I think that the value may be an int, so, causing a nuclear implosion. Probably nice to check for a concrete populated example, and eventually do line 27 or similar ones.

I have successfully updated this now, thank you for your help

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

In the future it may be nice to also have a getArgStr() that always return a string, never NULL. So, we can just if ( $to === '' )

I guess this is still waiting for someone to review it, and not for me to "land" it?

I had no idea that I am supposed to "land" these changes. Surely it should be the responsibility of the maintainers to decide into which release a change will go and when?

Whitelisting both vs and id sound good.

id, vs and /new/ in URL all affect content of the generated file.

In D25485#14022, @speck wrote:

I was thinking we might want to better enable multi-line messages and remove the Enter = submit for both desktop and mobile (on mobile making a send button like most other chat apps).

I spent only 5 minutes playing around on a diff to see what might make the url change. The diff id is probably the key one I’d be interested in keeping. I don’t know what the other params are for (even vs).

In D25478#13957, @speck wrote:

What do you think about keeping the current naming scheme but whitelisting a handful of query params to use instead of using them all? The timestamp adds noise and it's probably nice to see the ID of the diff in the filename, e.g. D25478.id1541.diff? Maybe just allow the the id parameter and regex that it's value is just a string of numbers.

add PHP version information to the view.

Hmm that stack trade doesn’t seem to contain the origin of the issue, likely getting lost through error handling or maybe it’s an incomplete stack trace.

After reverting my patch, I have the following backtrace:

This seems fine, though I wonder if we should introduce a phutil_empty_string() or phutil_is_empty_string function to avoid the double-negative logic. I think this reads more easily:

if (phutil_empty_string($from)) {
  throw new Exception()
}

Is there a stacktrace to work from here? I suspect nothing should really be passing null into phutil_encode_log() and there's likely another issue here. I prefer preventing passing null values into this rather than papering over the issue here in the depths of util functions.

Thank you so much for the header fix that’s been bugging me every time I use conpherence lol

In T15225#13714, @waldyrious wrote:

It's also misleading that the text box is multiline (at least in desktop) which suggests that line breaks are expected, but pressing Enter instead sends the message.

Add maniphest task to the commit message

Fix warning raised by the linter.

Okay, thanks. I've created T15681: PHP8 error running "ssh vcs-user@phorge.yourcompany.com conduit conduit.ping", commits via arcanist should follow soon :)

I'm just glossing over this - is ArcanistPhpunitTestResultParser now learning to parse generic "junit style xml" format?

Testing, using https://github.com/campbsb/example-phorge-php-project.git and breaking it so as to cause a test failure, we get:

• Add LIBXML_NONET option
• Remove $last_test_finished and the !last_test_finished block, as that is always true

Just as a reference point, a few years ago, I created a version of this as well - It supports readCoverage coverage reports, etc.