I cannot double-accept but I like this even more

git rebase master
arc lint
arc unit

Basically, it works :D

Tested, it works, thanks :) Just feel free to follow the suggestion

So, we are here if I understand correctly:

even more minor change

Ah, thanks for landing

This collapsible is interesting thanks!

Thanks again for this change

In D25420#12963, @speck wrote:

Instead of adding a checkbox is there precedent for having a separate button alongside Cancel and Submit?

Hoping to be useful, I will land this after 2023-11-07 :) Thanks for this nice feature

Hoping to be useful, I will land this in 3 days :) since I love this feature

Basically it works

Ah! Indeed it would be lovely

Where I can see the TOC in action? I think that I do not see that even here without ?as=remarkup:

Create a dedicated method getRemarkupLinkClass() to write that once

fix test

Integrate some tips. Clarify that this is just a compromise between performance and a good default, only to be used for target="_blank" purposes, to don't slow down Remarkup.

Hoping to be useful, implement tips, to be easily tested.

Thanks for reporting

Partially related to

I've done my best to implement all proposed improvements

Before this change NULL was indeed implicitly casted to ''

Ah, sorry @20after4 if I broke "your" Wikimedia Phabricator ihih

Yeah so we are all for "let's just append as default and maybe think about something more for the future, if they ask"

Hi @Matthew can I help in landing this useful change?

You have green light, feel free to land and thanks

Maybe we can expand the test plan:

Thanks for reporting.

Hi @bekay, feel free to look at D25408. It should fix your original problem. Thanks for your reporting

I've probably understood what is going on here

What about something like this?

Hoping to be useful, let's land this.

move comment

add useful comment (at least in my opinion) about $idx

I'm trying to propose two unit tests, but I'm not able to make them "fail" before the change. The unit always says "OK" so I think I'm not useful :( But here as reference:

git rebase master

I triage this to Wishlist since it's indeed useful to some people but it's somehow still controversial. In order to attract more eyes, adding also Discussion Needed.

Feel free to land \o/

What about this small change? So, the checkbox has not a related "left" label, and has a more descriptive "right" label.

Tested before/after, thanks :)