Page MenuHomePhorge
Differential D25458

Adjust message in timezone conflict form
ClosedPublic
Actions

Authored by waldyrious on Nov 7 2023, 15:59.

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Commits
rP8092d90c79fc: Adjust message in timezone conflict form
Summary

This applies a suggestion initially proposed in
https://we.phorge.it/D25420#12264

Test Plan
  • Change your browser/system timezone to differ from your Phorge profile timezone
  • Click the notice that Phorge shows at the bottom left about the timezone mismatch
  • Confirm that the form text has been changed as per the diff in this revision

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

waldyrious created this revision.Nov 7 2023, 15:59
Owners added a reviewer: O1: Blessed Committers.Nov 7 2023, 15:59
Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptNov 7 2023, 15:59
waldyrious requested review of this revision.Nov 7 2023, 15:59
Harbormaster completed remote builds in B887: Diff 1447.Nov 7 2023, 15:59
waldyrious mentioned this in Z5: Phorge (flame).Nov 7 2023, 15:59
aklapper awarded a token.Nov 8 2023, 08:00
aklapper subscribed.
valerio.bozzolan added inline comments.Nov 8 2023, 08:34
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
118

Maybe?

Thanks

valerio.bozzolan accepted this revision.Nov 8 2023, 08:36

Tested, it works, thanks :) Just feel free to follow the suggestion

This revision is now accepted and ready to land.Nov 8 2023, 08:36
waldyrious added inline comments.Nov 9 2023, 00:49
src/applications/settings/controller/PhabricatorSettingsTimezoneController.php
118

Yeah, sure. I'll make the change.

waldyrious updated this revision to Diff 1457.Nov 9 2023, 00:52
  • Adjust message per code review suggestion
Harbormaster completed remote builds in B897: Diff 1457.Nov 9 2023, 00:52
waldyrious marked an inline comment as done.Nov 9 2023, 00:57
Closed by commit rP8092d90c79fc: Adjust message in timezone conflict form. · Explain WhyNov 10 2023, 09:03
This revision was automatically updated to reflect the committed changes.
waldyrious added a commit: rP8092d90c79fc: Adjust message in timezone conflict form.

Revision Contents
Changeset List

PathSizePackages
src/
applications/
settings/
controller/
4 linesO1: Blessed Committers

Diff 1463

View Options

src/applications/settings/controller/PhabricatorSettingsTimezoneController.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0