Page MenuHomePhorge

Dashboard Panel: fix first tab sometime not opened anymore
ClosedPublic

Authored by valerio.bozzolan on Oct 12 2023, 13:37.
Tags
None
Referenced Files
F1397904: D25447.id1419.diff
Wed, Feb 21, 21:38
Unknown Object (File)
Tue, Feb 20, 13:25
Unknown Object (File)
Tue, Feb 20, 13:24
Unknown Object (File)
Tue, Feb 20, 13:20
Unknown Object (File)
Tue, Feb 20, 13:20
Unknown Object (File)
Tue, Feb 20, 13:04
Unknown Object (File)
Wed, Feb 14, 01:47
Unknown Object (File)
Tue, Feb 13, 16:07

Details

Summary

After this change the first Tab ID is always selected, so we don't risk
to have no tabs opened by default under some corner cases.

This is vaguely better than the original logic that relied on the fact that
(0=="0") is true. Besides being a vaguely weird emoticon as well, now that
I look at it better.

Original logic:

https://we.phorge.it/source/phorge/browse/master/src/applications/dashboard/paneltype/PhabricatorDashboardTabsPanelType.php;c43618a3a8bb021936fad687f04cb1a95faa23e4$289

This fixes a regression that appeared in the cute Wikimedia Phabricator
(that now is really Wikimedia Phorge). Their homepage should be gorgeous again,
without blank space due to unopened silly tabs.

Closes T15651

Test Plan
  • Have a Tab Panel (/dashboard/panel/).
  • Be sure that the first Tab is automatically selected (again?)

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

add useful comment (at least in my opinion) about $idx

This revision is now accepted and ready to land.Oct 16 2023, 06:19