Page MenuHomePhorge

Update PhutilCowsay.php to work for small cows
Needs ReviewPublic

Authored by Sten on Tue, Sep 12, 16:09.
Tags
None
Referenced Files
F357803: D25436.id.diff
Sun, Sep 24, 22:23
F357730: D25436.id1384.diff
Sun, Sep 24, 16:59
Unknown Object (File)
Thu, Sep 21, 09:01
Unknown Object (File)
Wed, Sep 20, 10:08
Unknown Object (File)
Tue, Sep 19, 01:08
Unknown Object (File)
Mon, Sep 18, 15:20
Unknown Object (File)
Mon, Sep 18, 09:38
Unknown Object (File)
Sat, Sep 16, 05:20

Details

Reviewers
None
Group Reviewers
O1: Blessed Committers
Summary

Update PhutilCowsay.php to work for small cows.

In doing so, we also simplify the code to just use multiline regexps rather than trying to parse a line at a time.

________________ < What about me? > ---------------- oo = ".." unless (oo); \ ,__, \ (oo)____ (__) )\ ||--|| *
Test Plan

Check cowsay works for the built in non-perl cow:

cowsay(cow='companion'){{{Built in}}}

Test all the perl cows:

cowsay(cow='bunny'){{{Testing bunny}}}
cowsay(cow='cower'){{{Testing cower}}}
cowsay(cow='daemon'){{{Testing daemon}}}
cowsay(cow='default'){{{Testing default}}}
cowsay(cow='dragon-and-cow'){{{Testing dragon-and-cow}}}
cowsay(cow='dragon'){{{Testing dragon}}}
cowsay(cow='elephant'){{{Testing elephant}}}
cowsay(cow='eyes'){{{Testing eyes}}}
cowsay(cow='flaming-sheep'){{{Testing flaming-sheep}}}
cowsay(cow='head-in'){{{Testing head-in}}}
cowsay(cow='kitty'){{{Testing kitty}}}
cowsay(cow='koala'){{{Testing koala}}}
cowsay(cow='meow'){{{Testing meow}}}
cowsay(cow='moofasa'){{{Testing moofasa}}}
cowsay(cow='moose'){{{Testing moose}}}
cowsay(cow='mutilated'){{{Testing mutilated}}}
cowsay(cow='satanic'){{{Testing satanic}}}
cowsay(cow='sheep'){{{Testing sheep}}}
cowsay(cow='skeleton'){{{Testing skeleton}}}
cowsay(cow='small'){{{Testing small}}}
cowsay(cow='squirrel'){{{Testing squirrel}}}
cowsay(cow='stegosaurus'){{{Testing stegosaurus}}}
cowsay(cow='supermilker'){{{Testing supermilker}}}
cowsay(cow='surgery'){{{Testing surgery}}}
cowsay(cow='turkey'){{{Testing turkey}}}
cowsay(cow='turtle'){{{Testing turtle}}}
cowsay(cow='tux'){{{Testing tux}}}
cowsay(cow='www'){{{Testing www}}}

Diff Detail

Repository
rARC Arcanist
Branch
smallCow (branched from master)
Lint
Lint Passed
Unit
Tests Passed
Build Status
Buildable 841
Build 841: arc lint + arc unit