Page MenuHomePhorge

Calendar: Impossible to import .ics file (Phorge checks for a non-existing remote URI)
Closed, ResolvedPublic

Description

  1. Have some example ICS calendar event file locally
  2. Go to https://we.phorge.it/calendar/import/edit/
  3. Select Import .ics file and select Continue button
  4. Under ICS File, select your local test case file
  5. Select the Create New Import button

Actual outcome:
You can not attach an ICS URI to an import type other than an ICS URI import (type is "icsfile").

Expected outcome:
I am importing a local ICS file and not a remote URI one, so I do not expect any errors about some URI.
I selected Import .ics file; I did not select Import .ics URI so the Create Import dialog should not show an URI field anyway. The latter is as expected in an older Phabricator version we're running (cannot offer our exact version as Version Information on https://phabricator.wikimedia.org/config/ shows "Unknown").
I'm afraid this is a regression from 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b

Revisions and Commits

Event Timeline

I confirm that there is no problem after running git revert 02a4f8b0c8f1279fc0040ad8077942fd8b0d948b.

Interesting. ICS URI import was fixed in 02a4f8b0c8f1279fc but at the cost of breaking ICS file import.

If you are not already working on this, I can dig a bit today in Singapore

I've invested 8 minutes in this and I'm somehow confused about the possible cause and solution :)

I've probably understood what is going on here