Page MenuHomePhorge
Differential D25449

Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
ClosedPublic
Actions

Authored by Sten on Oct 25 2023, 08:43.
Tags
None
Referenced Files
F3291303: D25449.1742877797.diff
Mon, Mar 24, 04:43
F3249277: D25449.1742285460.diff
Mon, Mar 17, 08:11
F3220888: D25449.1741813205.diff
Tue, Mar 11, 21:00
F3220115: D25449.1741800389.diff
Tue, Mar 11, 17:26
F2999903: D25449.1740433818.diff
Feb 23 2025, 21:50
F2999902: D25449.1740433817.diff
Feb 23 2025, 21:50
F2994666: D25449.1740324894.diff
Feb 22 2025, 15:34
F2992800: D25449.1740252083.diff
Feb 21 2025, 19:21
View All 26 Files
Subscribers
Cigaryno
Matthew
tobiaswiese
valerio.bozzolan

Details

Reviewers
valerio.bozzolan
Group Reviewers
O1: Blessed Committers
Maniphest Tasks
T15654: PhabricatorAuthCSRFEngine.php:50 strncmp(): Passing null to parameter #1 ($string1) of type string is deprecated
Commits
rP318d7a61feab: Fix PhabricatorAuthCSRFEngine.php strncmp(null) PHP 8.1 error
Summary

Update PhabricatorAuthCSRFEngine.php such that it doesn't fall over when provided with a null CSRF token under PHP 8.1

Fixes T15654

Test Plan

Do a POST request to phorge.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Revision Contents
Changeset List

PathSizePackages
src/
applications/
auth/
engine/
5 linesO1: Blessed Committers

Diff 1422

View Options

src/applications/auth/engine/PhabricatorAuthCSRFEngine.php

Loading...
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0