This revision's diff has been copied from Wikimedia. Please warn me if there is an error.
Ref T15082
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Maniphest Tasks
- T15082: Consider allowing milestone columns to be ordered arbitrarily on workboards
Reorder milestones in the menu.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Skipped - Unit
Tests Skipped
Event Timeline
Comment Actions
Maybe I can propose to control this new behavior by a new method:
public isMilestoneReordable() {
// historically this was false, but hey, this is a community edition
return true;
}So that Evan can keep this to false
So other installations can customize this thing
Comment Actions
Since this change is highly controversial from the opinion of the glorious Evan, I would like to propose to introduce a flag, like this one:
public isMilestoneReordable() {
return true; // if we are bold
return false; // if we are not bold
}Premising I have NOT a strong opinion about the default value, I think that a dedicated activation method is strongly necessary to allow Evan to disable this more easily, or Wikimedia to enable this more easily, without very minimal custom ad-hoc code.