(I accepted but before landing please first review all not-done inline comments: https://we.phorge.it/differential/revision/inlines/25420/ and this comment: https://we.phorge.it/D25420#12264 )

In D25420#12264, @waldyrious wrote:

I like this approach, and prefer it to my simpler attempt from D25426; but have some minor suggestions:

• Instead of "You can ignore this conflict or adjust your profile setting to match your client", we should use the same order in the sentence as the options are shown to the user: "You can adjust your profile setting to match your client, or ignore this conflict."
• The label for the checkbox should be just "Ignore Conflict", without the "Or" at the start.
• When the "Ignore Conflict" checkbox is selected, the timezone dropdown should be disabled (and re-enabled if the checkbox is unmarked)

Sorry, I mean this link:

I absolutely don't know what we are doing here since I don't know the supposed "Phabricator way" to interact with the DOM via JavaScript using its library.

Screenshot from:

We were able to push Phorge subliminal messages in an official Wikimedia video \o/

Yeah thanks! Maybe we can somehow keep the footer, in order to have a link for people like me that just have their brain switched-off and just look at the bottom link. Also maybe we can simplify a little bit.

Thanks for this patch. Yeah if I understand correctly, this should work:

I'm Valerio, a simple person: I see "GNU/Linux" and I say "yeah, land".

cosmetic whitespace changes

This is very promising. Just added an inline comment

This is very probably a recent regression since I cannot reproduce on Wikimedia Phabricator.

This happens also with the Upload File dialog

Ah! I can reproduce exactly in this comment!

consider more cases

fix corner case of NULL phid

It seems your "master" branch has (many?) local unexpected commits.

I kindly mark this as "request changes" since the author said that it needs an update to reflect the screenshot. Feel free to update with

Thanks Roberto, feel free to update D25420 to reflect your lovely screenshot.

Got it! Nice catch!

Interestingly I tried to open a simple README file and selecting UTF-8.

Thanks I'm trying to reproduce. Can you please help me in understanding "click to the left next to the up arrow icon"? I probably don't get "click the left"

I like so much this popup, thanks Roberto

I don't know how to add a third button in a modal, but I would agree on that approach.

Tested, seems good to me

In D25374#10923, @Matthew wrote:

Please fix unit errors

fix lint

This seems the exact backward-compatible thing to me

Maybe we can improve the current popup from current:

@aklapper Can you please share your stack trace?

Thanks. I would like to help in reviewing but I don't get the difference. Can you describe the inline change?

Hi @bekay, I think that D25408 fixes this problem

I don't love this, but this is a general fix:

I also don't fully understand the "Phabricator way" to create full text queries still using indexes. That is my main concern.

I will kindly mark this as request changes since unfortunately we have a crash if the $label is an object like PhutilSafeHTML.

In D25359#10790, @valerio.bozzolan wrote:

I noticed that Phorge exports the date in this format:

Date: 2023-08-02 23:23:38 (UTC+2)

While git exports the date in this format:

Thu Jun 29 23:23:28 2023 +0200

Is this known? Should we uniform these?

Thanks again \o/

OK so if I understand correctly:

I've invested 8 minutes in this and I'm somehow confused about the possible cause and solution :)

add noreferrer for privacy reasons