there is a presentation from eric brechner, who was in microsofts xbox development, about kanban. he does it on whiteboard, extremely sinple:
https://www.youtube.com/watch?v=CD0y-aU1sXo

Also related: https://phabricator.wikimedia.org/T266966

We may want to expand the Test Plan to mention additional tips to help newcomers in breaking their installation.

I love it, thanks.

It might be safer to do a null check with the strlen check in case the value isn’t a string.

Note that I did *not* test this locally yet; just putting it here so it does not get lost (again)

Still WIP, was just checking that nothing explodes locally (yet)

Tested, thanks! no nuclear implosions and I like it. I also think that "accadf" is more readable than before :^) please wait some days before landing to eventually attract additional testers.

arc lint

git commit --amend --author="Mukunda Modell"

Urgh, indeed not the brightest proposed patch (though it worked locally).
Also need to rework/expand patch because there are several more places in this very file to fix.
More stacktraces triggered by going to http://phorge.localhost/maniphest/ :

Also fix line 14

Thanks both! I'll land this, then.

Thanks @waldyrious - I agree with both you and @speck since I was affected by the first issue and since I believe that T15225 is a good thing. Tested, nice!

In D25488#14099, @aklapper wrote:

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...

Tested. No nuclear implosions :) Thanks!

If the patch was written by 20after4 we can probably set git commit --amend --author="Mukunda Modell". Can I help in this?

but very unlikely anyone would ever make the effort, with MySQL (and compatibles) being so easy to obtain.

Good catch. I don’t think it would cause an implosion but might result in not applying constraints when it should

I think that the value may be an int, so, causing a nuclear implosion. Probably nice to check for a concrete populated example, and eventually do line 27 or similar ones.

I have successfully updated this now, thank you for your help

Hmm, I guess the patch should also change line 14 in the same way? I managed to reach that line with the same problem but do not remember the exact steps I performed...