Page MenuHomePhorge
Feed All Stories

Dec 16 2023

avivey added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

That's odd...

  • do you have an entry for "https://we.phorge.it/api/" in your ~/.arcrc ?
  • I'm also confused about the --trace not including any comment about loading any configuration source - that's probably a bug
  • how about echo {} | arc --trace call-conduit -- user.whoami ? in the phorge dir and in other dirs?
  • I'm assuming /home/kuba/bin/arc is a symlink to arc that's in ~/Downloads/arc?
Dec 16 2023, 17:47
kuba-orlik added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

Also, commands like arc patch and arc diff --update work fine for me, it seems that only arc land is affected.

Dec 16 2023, 15:03
kuba-orlik updated the diff for D25497: Add example systemd unit for sshd in Diffusion docs.
  • Better syntax highlighting
Dec 16 2023, 15:01
kuba-orlik added a comment to Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).

Running with --trace gives me:

Dec 16 2023, 14:58
kuba-orlik asked Q101: Cannot land a diff - LOGIN REQUIRED (I am logged in).
Dec 16 2023, 14:58

Dec 15 2023

avivey added a comment to T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.

The highlighting process could track elapsed time and stop highlighting any further documents after a fixed amount of time elapses...

Dec 15 2023, 08:51
avivey awarded T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork a Like token.
Dec 15 2023, 08:51
waldyrious added a project to T15270: "Access Denied: Restricted File" strings concatenated without whitespace: UX.
Dec 15 2023, 08:49 · UX, Good Starter Task, Files
waldyrious added a project to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File": UX.
Dec 15 2023, 08:48 · UX
avivey closed Q93: The latest changes aren't reflected in the Setup Guide as resolved.
Dec 15 2023, 08:48
waldyrious added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Thanks for the note, Andre! I've went ahead and updated the revision as discussed above.

Dec 15 2023, 08:43 · UX
waldyrious updated the diff for D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".
  • Add spaces in HTML message builder instead of to each item text
Dec 15 2023, 08:42 · UX
valerio.bozzolan updated the diff for D25118: Remarkup: make less internal links open in new tabs.

fix PHPDoc (last version v2.4_final3_really51.zip)

Dec 15 2023, 08:16
valerio.bozzolan resigned from D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

(In the meanwhile, removing the red semaphore, since the goal was to attract reviewers and it worked asd)

Dec 15 2023, 08:07 · UX
aklapper added a comment to D25419: Fix the whitespace issue in the message "Access Denied: Restricted File".

Should I go ahead and submit a different patch? Or could I somehow contribute the edit to this patch?

Dec 15 2023, 03:51 · UX

Dec 14 2023

valerio.bozzolan added a comment to T15692: Allow to see your own public revoked key.

I totally agree with these additional considerations. Thanks.

Dec 14 2023, 21:27 · UX, User-valerio.bozzolan, Auth
valerio.bozzolan added a comment to T15161: Internal resources should avoid to become external links, as default.

Since I can, thanks to that revision, at work I've put this additional CSS rule for extra nonsense scary climax.

Dec 14 2023, 18:05 · User-valerio.bozzolan, Discussion Needed, Remarkup
20after4 added a comment to D25493: Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested.

@aklapper you are now a member of Blessed Committers.

Dec 14 2023, 17:51
20after4 added a member for Blessed Committers: aklapper.
Dec 14 2023, 17:48
20after4 awarded D25118: Remarkup: make less internal links open in new tabs a Love token.
Dec 14 2023, 17:46
valerio.bozzolan updated the diff for D25118: Remarkup: make less internal links open in new tabs.

fix PHPDoc

Dec 14 2023, 17:43
20after4 updated the task description for T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:38
20after4 updated the task description for T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:36
20after4 updated the task description for T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:35
20after4 added a parent task for T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork: T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 14 2023, 17:33
20after4 added a subtask for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge: T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:33 · Discussion Needed, Affects-Wikimedia
20after4 updated the task description for T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.
Dec 14 2023, 17:32 · Discussion Needed, Affects-Wikimedia
20after4 created T15694: Consider adopting the "search results context highlighting" feature from Wikimedia's fork.
Dec 14 2023, 17:30
valerio.bozzolan requested review of D25498: Fix Subversion "commit" support in PHP 8.1.
Dec 14 2023, 17:29
valerio.bozzolan added a revision to T15693: Fix Arcanist commit in PHP 8.1 (Subversion): D25498: Fix Subversion "commit" support in PHP 8.1.
Dec 14 2023, 17:29 · PHP 8 support, Arcanist, User-valerio.bozzolan
valerio.bozzolan triaged T15693: Fix Arcanist commit in PHP 8.1 (Subversion) as High priority.
Dec 14 2023, 17:21 · PHP 8 support, Arcanist, User-valerio.bozzolan
20after4 accepted D25493: Avoid "Undefined index" error in project.search API when project_customfieldstorage table has additional fields not requested.

Since this was vetted by epriestley and previously by myself as well. I think that it exceeded the minimum standard for code review before it landed here.

Dec 14 2023, 17:09
20after4 added a comment to T15081: Figure out if there are patches from Wikimedia's fork that are desirable to upstream in Phorge.

Here's another one that I think deserves to be upstreamed: https://phabricator.wikimedia.org/T230787 adds context and search term highlights to fulltext search results. Currently Phorge and upstream Phabricator only show matching document titles with highlights on keywords in the title but not the body.
The efficiency of my solution is questionable, however, it's working well enough for Wikimedia's use of the feature.

Dec 14 2023, 17:04 · Discussion Needed, Affects-Wikimedia
valerio.bozzolan updated the diff for D25118: Remarkup: make less internal links open in new tabs.
  • add dedicated class to handle things
  • add interesting test cases
  • ready for dinner
Dec 14 2023, 17:04
valerio.bozzolan updated the task description for T15161: Internal resources should avoid to become external links, as default.
Dec 14 2023, 16:42 · User-valerio.bozzolan, Discussion Needed, Remarkup
20after4 awarded T15169: New user on a Linux server with SSH (to be used only to Land stuff - Repository automation) a Love token.
Dec 14 2023, 16:39 · Phorge.it Systems, User-valerio.bozzolan, Blessed Roots
20after4 awarded D25497: Add example systemd unit for sshd in Diffusion docs a Love token.
Dec 14 2023, 16:36
valerio.bozzolan added a comment to D25497: Add example systemd unit for sshd in Diffusion docs.

For better syntax highlight feel free to adopt ,lang=ini in the code block. So, the line becomes:

Dec 14 2023, 12:05
speck accepted D25496: Fix typo.

Thanks!

Dec 14 2023, 12:05
valerio.bozzolan accepted D25497: Add example systemd unit for sshd in Diffusion docs.

I really appreciate this, and I can confirm that this systemd service is almost exactly the one I have in my production. Premising that in my production I've added also:

Dec 14 2023, 11:36
valerio.bozzolan added a revision to T15467: Document a systemd daemon: D25497: Add example systemd unit for sshd in Diffusion docs.
Dec 14 2023, 11:32 · User-valerio.bozzolan, Documentation
valerio.bozzolan retitled D25497: Add example systemd unit for sshd in Diffusion docs from Add an exapmle systemd unit for sshd in diffusion docs
Dec 14 2023, 11:32
valerio.bozzolan added a comment to T15467: Document a systemd daemon.

Partially related, a systemd unit for the SSH server. Proposal in D25497

Dec 14 2023, 11:32 · User-valerio.bozzolan, Documentation
valerio.bozzolan awarded D25497: Add example systemd unit for sshd in Diffusion docs a Love token.
Dec 14 2023, 11:26
kuba-orlik added a comment to Q92: Cannot submit a revision - mysql problems? (Answer 116).

Thanks, it was just a docs typo fix, so I ran the arc diff command with the --nounit flag

Dec 14 2023, 11:22
kuba-orlik requested review of D25497: Add example systemd unit for sshd in Diffusion docs.
Dec 14 2023, 11:21
kuba-orlik requested review of D25496: Fix typo.
Dec 14 2023, 11:12
avivey added a comment to T15692: Allow to see your own public revoked key.

Since we already show the full (public) key when editing, then I don't see a reason not to show it after it's revoked.

Dec 14 2023, 09:03 · UX, User-valerio.bozzolan, Auth

Dec 13 2023

valerio.bozzolan requested review of D25495: Auth SSH Details: show Public Key (not just Type).
Dec 13 2023, 16:52
valerio.bozzolan added a revision to T15692: Allow to see your own public revoked key: D25495: Auth SSH Details: show Public Key (not just Type).
Dec 13 2023, 16:52 · UX, User-valerio.bozzolan, Auth
valerio.bozzolan triaged T15692: Allow to see your own public revoked key as Normal priority.
Dec 13 2023, 16:04 · UX, User-valerio.bozzolan, Auth
valerio.bozzolan updated the name of F465329: Revoked SSH key.png from "image.png" to "Revoked SSH key.png".
Dec 13 2023, 16:03

Dec 12 2023

avivey added Q100: Undefined method when using celelery map on commit 2295bcda (Answer 127).
Dec 12 2023, 19:31
tvl asked Q100: Undefined method when using celelery map on commit 2295bcda.
Dec 12 2023, 18:28

Dec 11 2023

valerio.bozzolan updated the task description for T15673: Phorge participation at FOSDEM 2024.
Dec 11 2023, 12:47 · Blessed Communicators, Phorge
valerio.bozzolan added inline comments to D25118: Remarkup: make less internal links open in new tabs.
Dec 11 2023, 06:48
valerio.bozzolan updated the summary of D25118: Remarkup: make less internal links open in new tabs.
Dec 11 2023, 06:46

Dec 10 2023

speck added Q97: Unable to submit patch via arc diff (Answer 126).
Dec 10 2023, 23:42
valerio.bozzolan edited the content of 2023 week 49.
Dec 10 2023, 20:16
valerio.bozzolan edited the content of Next Up.
Dec 10 2023, 20:01
valerio.bozzolan edited the content of 2023 Week 32.
Dec 10 2023, 19:58
valerio.bozzolan added a comment to T15673: Phorge participation at FOSDEM 2024.

I'm quite sure that somebody of you will join FOSDEM. In case, please join this talk as presenter :)

Dec 10 2023, 19:49 · Blessed Communicators, Phorge
Rinalusi44 added a comment to D25466: Improve command line prompts in setup issue pages.
Dec 10 2023, 17:40 · Config, UX
valerio.bozzolan closed T15577: Show existing Hovercards from more places as Resolved by committing rP2295bcda14e7: Curtain: add Hovercard support.
Dec 10 2023, 15:55 · UX, User-valerio.bozzolan
valerio.bozzolan closed D25424: Curtain: add Hovercard support.
Dec 10 2023, 15:55
valerio.bozzolan committed rP2295bcda14e7: Curtain: add Hovercard support.
Curtain: add Hovercard support
Dec 10 2023, 15:55
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).

1b. Did you restart FastCGI after updating the code?

Dec 10 2023, 14:56
avivey closed Q99: permission to report a bug as resolved.
Dec 10 2023, 14:47
avivey added Q99: permission to report a bug (Answer 125).
Dec 10 2023, 14:46
avivey added a comment to Q95: Maniphest task: strlen(): Passing null to parameter #1 ($string) of type string is deprecated (Answer 122).
  1. Yes, you should have D25387 - which makes it very strange that you're getting an exception.
  2. That's the trace, yes.
  3. I've added you to Trusted Contributors, so you can file bugs in maniphest, etc.
Dec 10 2023, 14:46
avivey added a member for Trusted Contributors: adrelanos.
Dec 10 2023, 14:46
adrelanos asked Q99: permission to report a bug.
Dec 10 2023, 13:39
speck added inline comments to D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 01:48
aklapper requested review of D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 00:00
aklapper added a revision to T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured: D25494: Fix PHP 8.1 exception creating task when custom select field configured.
Dec 10 2023, 00:00 · PHP 8 support

Dec 9 2023

speck added a comment to T15645: Implement "Locate File" input in Browse view.

I’ve been meaning to investigate this. It also has thrown me that it’s not available where you expect it. I do suspect @valerio.bozzolan is right

Dec 9 2023, 23:59 · Diffusion
speck awarded T15645: Implement "Locate File" input in Browse view a Like token.
Dec 9 2023, 23:57 · Diffusion
aklapper updated the task description for T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured.
Dec 9 2023, 23:50 · PHP 8 support
aklapper created T15691: PHP 8.1 "strlen(null)" exception creating Maniphest task when custom select field configured.
Dec 9 2023, 23:50 · PHP 8 support
avivey marked Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123) as hidden.
Dec 9 2023, 08:46
avivey accepted D25424: Curtain: add Hovercard support.
Dec 9 2023, 08:44

Dec 8 2023

valerio.bozzolan added a comment to T15645: Implement "Locate File" input in Browse view.

I wonder if under the hood this means "Add branch support to Locate File"

Dec 8 2023, 20:01 · Diffusion
valerio.bozzolan updated the task description for T15577: Show existing Hovercards from more places.
Dec 8 2023, 19:58 · UX, User-valerio.bozzolan
avivey renamed 2023 week 49 from 2023.49 RC to 2023 week 49 RC.
Dec 8 2023, 17:38
avivey edited the content of Change Log.
Dec 8 2023, 17:38
avivey closed T15554: Handling PHP deprecations: convert to Setup Issues as Resolved.

Unless something broke, this task is now complete.

Dec 8 2023, 17:37 · Phorge
avivey renamed 2023 week 49 from Next Up to 2023.49 RC.
Dec 8 2023, 17:36
avivey added inline comments to D25388: PhutilErrorHandler: support multiple error listeners.
Dec 8 2023, 16:05
avivey created T15690: PhutilErrorHandler - add try/catch around `call_user_func`.
Dec 8 2023, 16:04
avivey closed D25440: Show Deprecation Warnings as Setup Warnings.
Dec 8 2023, 15:56
avivey committed rP2ba2cbaf9bbf: Show Deprecation Warnings as Setup Warnings.
Show Deprecation Warnings as Setup Warnings
Dec 8 2023, 15:56
avivey created T15689: built in exception display is missing top line.
Dec 8 2023, 15:54 · Phorge Development Tools
avivey edited the content of Report Warnings.
Dec 8 2023, 15:42
avivey updated the diff for D25440: Show Deprecation Warnings as Setup Warnings.
  • add PHP version
  • rebase
Dec 8 2023, 15:41
bekay claimed T15645: Implement "Locate File" input in Browse view.

Well, no opinions from the team. I still think this should be implemented... 😁

Dec 8 2023, 13:27 · Diffusion
deric updated the answer details for Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 124).
Dec 8 2023, 10:15
deric added a comment to Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).

I'm trying debug mode

./bin/phd debug PhabricatorTaskmasterDaemon
Dec 8 2023, 09:59
deric added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 124).
Dec 8 2023, 08:46
avivey added Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker (Answer 123).
Dec 8 2023, 08:36
deric updated the question details for Q98: Unable to start phd daemons, missing PhabricatorRepositoryCommitOwnersWorker.
Dec 8 2023, 08:17