For some reasons I'm not able to trigger this problem, but that seems perfect to me, thaaaaanks
- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
Feed All Stories
All Stories
All Stories
Aug 17 2023
Aug 17 2023
valerio.bozzolan added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
bob committed rP747d7db24161: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
As a minion, I'm only working for the glory of my boss ! :P
valerio.bozzolan added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Yeah feel free to land this as-is, that was easy-peasy accepted
bob committed rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion.
Fix source code viewer background color when using Dark Mode in Diffusion
Updating D25399: Reverting formatUser method prototype
valerio.bozzolan added a comment to D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Nice thaaanks
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Thanks for the patch suggestion ! Then we can :
Fix a PHP 8.1 deprecated use of preg_match with a NULL argument
valerio.bozzolan retitled D25397: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of preg_match with a NULL argument
Yeah thanks
valerio.bozzolan retitled D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument
valerio.bozzolan added a comment to D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.
Thanks for this change! Just a small thing
valerio.bozzolan added inline comments to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Aug 16 2023
Aug 16 2023
Looks safe and sensible.
I removed another diff's modification included by Arcanist (there is definitely something about arc command that I'm missing...)
When an fatal exception is triggered :
bob updated the summary of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Because there are more and more referenced issues and, because some of them may need further discussion in order to find the best solution, IMHO it may be a good idea to create a sub task for each issue reported isn't it ?
bob updated the diff for D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
Updating D25396: Include updated celerity map file
bob requested review of D25396: Fix source code viewer background color when using Dark Mode in Diffusion.
aklapper closed T15606: PHP 8.1 "strlen(null)" exception on "Link External Account" page at login, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP9fa9aa30b940: Fix PHP 8.1 "strlen(null)" exception on "Link External Account" page at login.
Fix PHP 8.1 "strlen(null)" exception on "Link External Account" page at login
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
I was updating the diff when I saw below that function getWebsocketURI may also be affected by a NULL issue :
bob updated the diff for D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Updating D25382: Update commit accordingly to comments
avivey accepted D25395: Fix PHP 8.1 "strlen(null)" exception on "Link External Account" page at login.
One day, we'd like pht() to return an object (non-string), but we'll handle that when we get there I guess.
I removed another commit that Arcanist sent in this diff
bob updated the diff for D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Updating D25382: Update commit accordingly to comments
avivey added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
In D25382#11307, @bob wrote:Do you mean ?
...
aklapper closed T15604: PHP 8.1 "strlen(null)" exception listing >100 task search results, a subtask of T15064: Make Phorge compatible with PHP 8.1/8.2/8.3/8.4, as Resolved.
aklapper committed rP29493f8a5c95: Fix PHP 8.1 "strlen(null)" exception listing >100 task search results.
Fix PHP 8.1 "strlen(null)" exception listing >100 task search results
aklapper added a comment to D25392: Fix PHP 8.1 "strlen(null)" exception listing >100 task search results.
Right... I also quickly tested with Conduit: On http://phorge.localhost/conduit/method/maniphest.search/ entering integer values like 12 or 91 in the fields before, after, limit and this one-liner doesn't show an exception anymore. And same for older http://phorge.localhost/conduit/method/maniphest.query/ and the fields limit and offset there - no exceptions.
bob added a comment to D25382: Fix a PHP 8.1/8.2 deprecated use of ltrim and rtrim with a NULL argument.
Do you mean ?
Fix icon background color when using Dark Mode
valerio.bozzolan accepted D25392: Fix PHP 8.1 "strlen(null)" exception listing >100 task search results.
I tested this without finding any nuclear implosion. Thanks!
Aug 15 2023
Aug 15 2023
Tweaks per review
Forgot the celerity thing
Added .device-desktop to some selectors as requested
In D25305#10771, @valerio.bozzolan wrote:Can you share a nice A/B test on Microsoft Windows to upload?
aklapper added a comment to T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
I confirm for e.g. https://we.phorge.it/D25079 or https://we.phorge.it/D25079?id=355 or https://we.phorge.it/D25079?id=360 that this only happens when not being logged in. Or on https://we.phorge.it/D25342?id=1111 stacking four errors on top of each other.
aklapper renamed T15559: Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out from Unhandled exception shown for open differential revisions containing changes to images to Exception "Failed to load file data for changeset" shown for Differential revisions containing changes to images and user being logged out.
aklapper requested review of D25392: Fix PHP 8.1 "strlen(null)" exception listing >100 task search results.
valerio.bozzolan awarded D25378: Fix PHP 8.1 "strlen(null)" exception adding an External Build Systems build step in Harbormaster a Orange Medal token.
valerio.bozzolan updated the diff for D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
arc lint
arc unit
aklapper added a comment to D25374: Fix PHP 8.1 "urlencode(null)" exception blocking account registration redirect for custom OAuth provider.
In D25374#10923, @Matthew wrote:Please fix unit errors
aklapper committed rP7040bd525764: Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step….
Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step…
Content licensed under Creative Commons Attribution-ShareAlike 4.0 (CC-BY-SA) unless otherwise noted; code licensed under Apache 2.0 or other open source licenses. · CC BY-SA 4.0 · Apache 2.0