Page MenuHomePhorge

Fix a PHP 8.1 deprecated use of strlen with a NULL argument
ClosedPublic

Authored by bob on Aug 16 2023, 15:38.
Tags
None
Referenced Files
F2305587: D25398.1721156301.diff
Mon, Jul 15, 18:58
Unknown Object (File)
Mon, Jul 15, 09:27
Unknown Object (File)
Sun, Jul 14, 16:30
Unknown Object (File)
Sun, Jul 14, 07:33
Unknown Object (File)
Sat, Jul 13, 13:52
Unknown Object (File)
Fri, Jul 12, 00:11
Unknown Object (File)
Thu, Jul 11, 00:47
Unknown Object (File)
Wed, Jul 10, 03:26

Details

Summary

This call is preventing users to browse Subversion repositories.
Using strlen() to check string validity is deprecated since PHP 8.1, phorge adopts phutil_nonempty_string() as a replacement.

Note: this may highlight other absurd input values that might be worth correcting
instead of just ignoring. If phutil_nonempty_string() throws an exception in your
instance, report it to Phorge to evaluate and fix that specific corner case.

Fix T15608

Test Plan
  • Sign in
  • Open a Diffusion SVN repository
  • You should see the repository instead of getting a Runtime Exception

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 16 2023, 15:38
valerio.bozzolan retitled this revision from Fix a PHP 8.1/8.2 deprecated use of strlen with a NULL argument to Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 18 2023, 11:04
valerio.bozzolan edited the summary of this revision. (Show Details)
valerio.bozzolan edited the test plan for this revision. (Show Details)
Sten subscribed.

Looks good to me.

This revision is now accepted and ready to land.Aug 18 2023, 13:46