- Queries
- All Stories
- Search
- Advanced Search
- Transactions
- Transaction Logs
All Stories
Aug 18 2023
This happened some minutes ago to our friend @waldyrious and I was able to reproduce it on my local computer. I've attached my reproducing instructions.
Maybe to be it consistent with "super-rebranded-product/" :D I don't know
I don't understand why the pht was there - it's a "path", why would it be translated?
Yeah fixed in D25104
I've just:
Oops, sorry, I was not on master. I was actually testing out D25079. This is already fixed on master, by @valerio.bozzolan.
git rebase master
Let's visually mark this as needing still some work
Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:
Great news ! I'll land it right now !
I've tested this in place with my eyes on a friend's laptop with PHP 8.1 in the very same problem
Nice job, my little and cute bob.. OH NO! a super-important regression! all of you minions will be fired soon!1!
OK I've found that this is about the legacy Conduit entry point for Paste.
I'm not able to trigger that part of the code.
Tested with and without a value, thaaanks \o/
Aug 17 2023
Revision has been updated. Any idea why tests/lint were skipped ?
Updating D25394: Simplify base_uri variable check
Tested, nice thaaaanks, with and without dark mode.
Also this is an excuse to run arc diff again, since tests and lints were skippeds :^)
I just mean that if($something) is usually avoided in Phorge "only and mainly" because if("0") is counter-intuitively false (so "0" is falsy even if it's a non-empty string). But here, we have not that problem, since "0" is a don't care value.
IMO, this depends on the objective of this check, I mean, does this check aim to verify if this parameter is defined or does it aim to verify if this parameter looks valid...
Maybe I'm wrong but I guess that the first option was in mind here else a regex would probable be a better approach since the "1" would be considered as a valid URI whereas "0" would not...
Thaanks bob
Several ideas/leads about the fact you cannot reproduce :