This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.
Details
Details
- Reviewers
valerio.bozzolan - Group Reviewers
O1: Blessed Committers - Commits
- rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
This is hard to say since I didn't know how/when this function might be called.
Diff Detail
Diff Detail
- Repository
- rP Phorge
- Lint
Lint Not Applicable - Unit
Tests Not Applicable
Event Timeline
Comment Actions
Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:
$ grep -R '>getWebsocketURI' . ./src/view/page/PhabricatorStandardPageView.php: $client_uri = $server->getWebsocketURI();
So this change seems perfectly legitimate to me. Thanks for this fix!