Page MenuHomePhorge

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument

Authored by bob on Aug 17 2023, 08:53.
Referenced Files
Unknown Object (File)
Wed, Jun 12, 16:15
Unknown Object (File)
Wed, Jun 12, 01:12
Unknown Object (File)
Tue, Jun 11, 10:03
Unknown Object (File)
Sat, Jun 8, 05:53
Unknown Object (File)
Fri, May 31, 20:41
Unknown Object (File)
Thu, May 30, 01:54
Unknown Object (File)
Wed, May 22, 07:02
Unknown Object (File)
May 19 2024, 22:10



This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16