Page MenuHomePhorge

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument

Authored by bob on Aug 17 2023, 08:53.
Referenced Files
Unknown Object (File)
Thu, Sep 21, 09:28
Unknown Object (File)
Sun, Sep 3, 05:15
Unknown Object (File)
Sat, Sep 2, 23:47
Unknown Object (File)
Wed, Aug 30, 12:27
Unknown Object (File)
Wed, Aug 30, 01:23
Unknown Object (File)
Tue, Aug 29, 17:13
Unknown Object (File)
Mon, Aug 28, 04:39
Unknown Object (File)
Sun, Aug 27, 00:03



This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

rP Phorge
Lint Not Applicable
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16