Differential D25401

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument
ClosedPublic
Actions

Authored by bob on Aug 17 2023, 08:53.

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument

Summary

This commit harmonizes PhabricatorNotificationServerRef's getURI and getWebsocketURI methods as discussed in D25382.

Test Plan

This is hard to say since I didn't know how/when this function might be called.

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bob created this revision.Aug 17 2023, 08:53

Owners added a reviewer: O1: Blessed Committers.Aug 17 2023, 08:53

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 17 2023, 08:53

bob requested review of this revision.Aug 17 2023, 08:53

Harbormaster completed remote builds in B771: Diff 1280.Aug 17 2023, 08:53

Thanks bob! You are a good minion. As discussed previously, this is used only in one point and without any argument:

$ grep -R '>getWebsocketURI' .
./src/view/page/PhabricatorStandardPageView.php:        $client_uri = $server->getWebsocketURI();

So this change seems perfectly legitimate to me. Thanks for this fix!

This revision is now accepted and ready to land.Aug 18 2023, 07:16

Closed by commit rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument. · Explain WhyAug 18 2023, 07:20

This revision was automatically updated to reflect the committed changes.

bob added a commit: rP7f46a252f21e: Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argument.

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

Path

Size

Packages

src/

applications/

notification/

client/

PhabricatorNotificationServerRef.php

4 lines

O1: Blessed Committers

Diff 1291

View Options

src/applications/notification/client/PhabricatorNotificationServerRef.php

Fix a PHP 8.1/8.2 deprecated use of strlen a NULL argumentClosedPublicActions