Page MenuHomePhorge

Fix source code viewer background color when using Dark Mode in Diffusion
ClosedPublic

Authored by bob on Aug 16 2023, 14:41.
Tags
None
Referenced Files
Unknown Object (File)
Sat, Jun 15, 09:57
Unknown Object (File)
Wed, Jun 12, 17:32
Unknown Object (File)
Wed, Jun 12, 16:00
Unknown Object (File)
Wed, Jun 12, 02:34
Unknown Object (File)
Tue, Jun 11, 23:56
Unknown Object (File)
Sat, Jun 8, 04:54
Unknown Object (File)
Fri, May 31, 20:39
Unknown Object (File)
Thu, May 30, 09:01

Details

Summary

This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal
to address this issue but it may be a good idea to create a different CSS variable (for instance source.background)
in order to avoid any potential side effect in the future.

BeforeAfter
screenshot-phorge-bug-darkmode-source-view-before.png (536×1 px, 30 KB)
screenshot-phorge-bug-darkmode-source-view-after.png (536×1 px, 49 KB)

Fix : T15056

Test Plan
  • Flush all Phorge caches
  • Sign in
  • Open a diffusion repository
  • Open any file
  • Check that viewer background color is consistent with the theme.

Diff Detail

Repository
rP Phorge
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

bob requested review of this revision.Aug 16 2023, 14:41

Updating D25396: Include updated celerity map file

Nice thaaanks

I agree that a follow-up change could improve even more the situation, but this just looks great both in white mode, and in dark mode.

Tested, no nuclear implosions, and celerity is updated, I also brushed my teeth correctly.

sgtm

This revision is now accepted and ready to land.Aug 17 2023, 08:25