Differential D25396

Fix source code viewer background color when using Dark Mode in Diffusion
ClosedPublic
Actions

Authored by bob on Aug 16 2023, 14:41.

Tags

None

Referenced Files

	Unknown Object (File)
	Wed, Apr 24, 22:22

	Unknown Object (File)
	Wed, Apr 24, 21:50

	Unknown Object (File)
	Fri, Apr 5, 14:09

	Unknown Object (File)
	Mon, Apr 1, 03:49

	Unknown Object (File)
	Mon, Apr 1, 02:38

	Unknown Object (File)
	Mon, Apr 1, 02:38

	Unknown Object (File)
	Mon, Apr 1, 02:38

	Unknown Object (File)
	Mon, Apr 1, 02:38

View All 89 Files

Subscribers

valerio.bozzolan

Details

Reviewers

valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Commits

rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion

Summary

This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal
to address this issue but it may be a good idea to create a different CSS variable (for instance source.background)
in order to avoid any potential side effect in the future.

Before	After

Fix : T15056

Test Plan

Flush all Phorge caches
Sign in
Open a diffusion repository
Open any file
Check that viewer background color is consistent with the theme.

Diff Detail

Repository

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bob created this revision.Aug 16 2023, 14:41

Owners added a reviewer: O1: Blessed Committers.Aug 16 2023, 14:41

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2023, 14:41

bob requested review of this revision.Aug 16 2023, 14:41

Harbormaster completed remote builds in B764: Diff 1269.Aug 16 2023, 14:41

Updating D25396: Include updated celerity map file

Harbormaster completed remote builds in B765: Diff 1270.Aug 16 2023, 14:43

bob mentioned this in T15056: Improve Dark Mode.Aug 16 2023, 14:44

bob edited the summary of this revision. (Show Details)Aug 16 2023, 14:50

Nice thaaanks

I agree that a follow-up change could improve even more the situation, but this just looks great both in white mode, and in dark mode.

Tested, no nuclear implosions, and celerity is updated, I also brushed my teeth correctly.

sgtm

valerio.bozzolan accepted this revision.Aug 17 2023, 08:25

This revision is now accepted and ready to land.Aug 17 2023, 08:25

Closed by commit rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion. · Explain WhyAug 17 2023, 08:31

This revision was automatically updated to reflect the committed changes.

bob added a commit: rP17befe9bca5b: Fix source code viewer background color when using Dark Mode in Diffusion.

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39

Revision Contents
Changeset List

Path

Size

Packages

resources/

celerity/

O1: Blessed Committers

webroot/

rsrc/

css/

layout/

phabricator-source-code-view.css

2 lines

O1: Blessed Committers

Diff 1278

resources/celerity/map.php

Loading...

webroot/rsrc/css/layout/phabricator-source-code-view.css

Loading...