HomePhorge
Diffusion Phorge 3f5fcdf4ddd8

Fix icon background color when using Dark Mode
3f5fcdf4ddd8
Actions

Description

Fix icon background color when using Dark Mode

Summary:
This CSS fix replaces the hard coded background gradient (white) value of icons when using Dark Mode.

Now the "Choose User Icon" popup has visible icons.

BeforeAfter
Choose User Icon Dark Mode - Broken.png (329×582 px, 14 KB)
Choose User Icon Dark Mode - Fixed.png (329×582 px, 16 KB)

Ref T15056

Test Plan:

  • Flush all Phorge caches
  • Sign in
  • Go to user's Settings > Display Preferences and select the Accessibility (user interface) "Dark Mode".
  • Go to user's profile, edit profile and click on Choose icon.
  • Check that now the icons in "Choose User Icon" are visible.
  • Do these steps for each user interface theme in order to check against regression.

Reviewers: O1 Blessed Committers, Matthew, valerio.bozzolan

Reviewed By: O1 Blessed Committers, Matthew, valerio.bozzolan

Subscribers: speck, tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Maniphest Tasks: T15056

Differential Revision: https://we.phorge.it/D25384

Details

Provenance
bobAuthored on Aug 14 2023, 09:05
bobPushed on Aug 16 2023, 08:30
Reviewer
O1: Blessed Committers
Differential Revision
D25384: Fix icon background color when using Dark Mode
Parents
rP7040bd525764: Fix PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step…
Branches
Unknown
Tags
Unknown
Tasks
T15056: Improve Dark Mode

Changes (2)

PathSizePackages
resources/
celerity/
O1: Blessed Committers
webroot/
rsrc/
css/
phui/
O1: Blessed Committers

rP3f5fcdf4ddd8

View Options

resources/celerity/map.php

Loading...
View Options

webroot/rsrc/css/phui/phui-icon-set-selector.css

Loading...