Page MenuHomePhorge

PHP 8.1 "strlen(null)" exception adding "Build with Buildkite" build step in Harbormaster
Closed, ResolvedPublic

Description

  1. PHP 8.2.8; Phorge at 226f3150933dfd735da17f19147e2648a5f54e63 with D25378 on top
  2. Create a Harbormaster Build Plan at http://phorge.localhost/harbormaster/plan/edit/form/default/ (this requires applying D25376)
  3. Go to resulting http://phorge.localhost/harbormaster/plan/1/
  4. Select Add Build Step to go to http://phorge.localhost/harbormaster/step/add/1/
  5. Select under "Interacting with External Build Systems": "Build with Buildkite" to go to http://phorge.localhost/harbormaster/step/new/1/HarbormasterBuildkiteBuildStepImplementation/
  6. Fill in no data; directly select the Create Build Step button
[2023-08-06 21:01:52] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]
arcanist(head=customOAuthUrlencodeNull, ref.master=788098096e11, ref.customOAuthUrlencodeNull=4f0f2043b7e9), phorge(head=master, ref.master=226f3150933d)
  #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/infrastructure/customfield/standard/PhabricatorStandardCustomField.php:271]
  #1 <#2> PhabricatorStandardCustomField::readValueFromRequest(AphrontRequest) called at [<phorge>/src/infrastructure/customfield/field/PhabricatorCustomField.php:1232]
  #2 <#2> PhabricatorCustomField::readValueFromRequest(AphrontRequest) called at [<phorge>/src/infrastructure/customfield/field/PhabricatorCustomFieldList.php:226]
  #3 <#2> PhabricatorCustomFieldList::buildFieldTransactionsFromRequest(HarbormasterBuildStepTransaction, AphrontRequest) called at [<phorge>/src/applications/harbormaster/controller/HarbormasterStepEditController.php:92]
  #4 <#2> HarbormasterStepEditController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]
  #5 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41]
  #6 PhabricatorDefaultRequestExceptionHandler::handleRequestThrowable(AphrontRequest, RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:751]
  #7 AphrontApplicationConfiguration::handleThrowable(RuntimeException) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:296]
  #8 AphrontApplicationConfiguration::processRequest(AphrontRequest, PhutilDeferredLog, AphrontPHPHTTPSink, MultimeterControl) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:203]
  #9 AphrontApplicationConfiguration::runHTTPRequest(AphrontPHPHTTPSink) called at [<phorge>/webroot/index.php:35]

Related Objects