Fix a PHP 8.1 deprecated use of preg_match with a NULL argument
ClosedPublic
Actions

Authored by bob on Aug 16 2023, 15:15.

Details

Reviewers

Sten
valerio.bozzolan

Group Reviewers

O1: Blessed Committers

Maniphest Tasks

T15607: PHP 8.2 "preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated" in diffusion

Commits

rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument

Summary

These calls are preventing users to browse subversion/mercurial repositories in PHP 8.1+.
Indeed, a similar bug affecting git repositories was already addressed in another commit
(rP6b8ec50148909938850b5acfd11725ae23a8e31b). This commit harmonize both DiffusionSvnRequest
and DiffusionMercurialRequest with DiffusionGitRequest

Fix T15607

Test Plan

Sign in
Open a diffusion SVN/Mercurial repository
You should not get a RuntimeException concerning this preg_match call

Diff Detail

Repository

rP Phorge

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

bob created this revision.Aug 16 2023, 15:15

Owners added a reviewer: O1: Blessed Committers.Aug 16 2023, 15:15

Herald added subscribers: Cigaryno, Matthew, valerio.bozzolan, tobiaswiese. · View Herald TranscriptAug 16 2023, 15:15

bob requested review of this revision.Aug 16 2023, 15:15

Harbormaster completed remote builds in B766: Diff 1271.Aug 16 2023, 15:15

I removed another diff's modification included by Arcanist (there is definitely something about arc command that I'm missing...)

bob mentioned this in D25398: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 16 2023, 15:38

bob mentioned this in D25399: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 16 2023, 16:05

bob mentioned this in D25400: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 16 2023, 16:17

Looks safe and sensible.

Yeah thanks

sgtm

This revision is now accepted and ready to land.Aug 17 2023, 08:00

valerio.bozzolan retitled this revision from Fix a PHP 8.1/8.2 deprecated use of preg_match with a NULL argument to Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.Aug 17 2023, 08:00

valerio.bozzolan edited the summary of this revision. (Show Details)

Closed by commit rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument. · Explain WhyAug 17 2023, 08:16

This revision was automatically updated to reflect the committed changes.

bob added a commit: rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument.

bob mentioned this in rP6ec89e9f0866: Fix a PHP 8.1 deprecated use of strlen with a NULL argument.Aug 18 2023, 10:48

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 19 2023, 04:47

valerio.bozzolan mentioned this in Wikimania Hackathon 2023 Singapore.Aug 28 2023, 16:39