Page MenuHomePhorge

PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer
Closed, ResolvedPublic

Description

If you try to view a subversion commit, you get a Runtime Exception with the stacktrace below :

PHP message: [2023-08-16 15:45:00] EXCEPTION: (RuntimeException) strlen(): Passing null to parameter #1 ($string) of type string is deprecated at [<arcanist>/src/error/PhutilErrorHandler.php:261]; 
PHP message: arcanist(head=master, ref.master=df6c315ace5f), phorge(head=master, ref.master=9fa9aa30b940); 
PHP message:   #0 <#2> PhutilErrorHandler::handleError(integer, string, string, integer) called at [<phorge>/src/applications/diffusion/data/DiffusionCommitRef.php:134]; 
PHP message:   #1 <#2> DiffusionCommitRef::formatUser(NULL, NULL) called at [<phorge>/src/applications/diffusion/data/DiffusionCommitRef.php:125]; 
PHP message:   #2 <#2> DiffusionCommitRef::getCommitter() called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommitData.php:133]; 
PHP message:   #3 <#2> PhabricatorRepositoryCommitData::getCommitterString() called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:528]; 
PHP message:   #4 <#2> PhabricatorRepositoryCommit::getRawCommitterStringForDisplay() called at [<phorge>/src/applications/repository/storage/PhabricatorRepositoryCommit.php:495]; 
PHP message:   #5 <#2> PhabricatorRepositoryCommit::newCommitCommitterView(PhabricatorUser) called at [<phorge>/src/applications/diffusion/controller/DiffusionCommitController.php:636]; 
PHP message:   #6 <#2> DiffusionCommitController::buildPropertyListView(PhabricatorRepositoryCommit, PhabricatorRepositoryCommitData, array) called at [<phorge>/src/applications/diffusion/controller/DiffusionCommitController.php:186]; 
PHP message:   #7 <#2> DiffusionCommitController::handleRequest(AphrontRequest) called at [<phorge>/src/aphront/configuration/AphrontApplicationConfiguration.php:284]; PHP message:   #8 phlog(RuntimeException) called at [<phorge>/src/aphront/handler/PhabricatorDefaultRequestExceptionHandler.php:41];

Related Objects

View Standalone Graph
This task is connected to more than 200 other tasks. Only direct parents and subtasks are shown here. Use View Standalone Graph to show more of the graph.

Event Timeline

valerio.bozzolan renamed this task from PHP 8.2 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer to PHP 8.1 "strlen(): Passing null to parameter #1 ($string) of type string is deprecated" in svn commit viewer.Aug 18 2023, 07:41
valerio.bozzolan triaged this task as Normal priority.