HomePhorge

Fix source code viewer background color when using Dark Mode in Diffusion

Description

Fix source code viewer background color when using Dark Mode in Diffusion

Summary:
This CSS fix replaces the hard coded white background value by the diff.background CSS variable. This is a proposal
to address this issue but it may be a good idea to create a different CSS variable (for instance source.background)
in order to avoid any potential side effect in the future.

BeforeAfter
screenshot-phorge-bug-darkmode-source-view-before.png (536×1 px, 30 KB)
screenshot-phorge-bug-darkmode-source-view-after.png (536×1 px, 49 KB)

Fix : T15056

Test Plan:

  • Flush all Phorge caches
  • Sign in
  • Open a diffusion repository
  • Open any file
  • Check that viewer background color is consistent with the theme.

Reviewers: O1 Blessed Committers, valerio.bozzolan

Reviewed By: O1 Blessed Committers, valerio.bozzolan

Subscribers: tobiaswiese, valerio.bozzolan, Matthew, Cigaryno

Differential Revision: https://we.phorge.it/D25396

Details

Provenance
bobAuthored on Aug 17 2023, 08:31
bobPushed on Aug 17 2023, 08:31
Reviewer
O1: Blessed Committers
Differential Revision
D25396: Fix source code viewer background color when using Dark Mode in Diffusion
Parents
rPa5d8b2d5cfd6: Fix a PHP 8.1 deprecated use of preg_match with a NULL argument
Branches
Unknown
Tags
Unknown