Page MenuHomePhorge
Feed All Stories

Aug 3 2023

Sten updated the diff for D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.
  • Just checked the getSourceControlBaseRevision() functions
Aug 3 2023, 09:30
valerio.bozzolan accepted D25355: Fix jshint tests.

I honestly still do not understand what is happening here, what does it mean disabled:3:1:E043 or error:3:1:E019 or anything, but:

Aug 3 2023, 09:18
valerio.bozzolan added a comment to T15056: Improve Dark Mode.

Hi @Bukkit can you please publish F281219? thanks :)

Aug 3 2023, 09:08 · User-Cigaryno, User-valerio.bozzolan, Accessibility, User-Bukkit
valerio.bozzolan added a comment to T15582: Allow blocking users.

And, just to clarify, have MediaWiki something similar? Probably the "Mute User". Is Mute user the needed thing?

Aug 3 2023, 09:00 · Clarification Needed
valerio.bozzolan added a comment to T15582: Allow blocking users.

We could expand a bit the Task description to clarify why the Disable User button and the Remove User are not sufficient for this purpose.

Aug 3 2023, 08:59 · Clarification Needed
Quartz created T15582: Allow blocking users.
Aug 3 2023, 08:47 · Clarification Needed
valerio.bozzolan added a comment to T15410: Discussion: stacked diffs / dependent revisions.

I think that D25359 is a nice example of a complete use case, where one Diff from one repo depends from another Diff from another repo.

Aug 3 2023, 08:17 · Differential

Aug 2 2023

valerio.bozzolan merged T15252: Using a raw git diff asks for repository, then loses it into T15537: When creating revision from raw diff, "Repository" field is lost.
Aug 2 2023, 21:31 · UX, User-valerio.bozzolan, Differential
valerio.bozzolan merged task T15252: Using a raw git diff asks for repository, then loses it into T15537: When creating revision from raw diff, "Repository" field is lost.
Aug 2 2023, 21:31 · UX, Differential
valerio.bozzolan added a comment to D25359: Generate more fields in Download Raw Diff.

I noticed that Phorge exports the date in this format:

Aug 2 2023, 21:27 · Differential
valerio.bozzolan updated the summary of D25359: Generate more fields in Download Raw Diff.
Aug 2 2023, 21:22 · Differential
valerio.bozzolan added inline comments to D25359: Generate more fields in Download Raw Diff.
Aug 2 2023, 20:45 · Differential
valerio.bozzolan added inline comments to D25359: Generate more fields in Download Raw Diff.
Aug 2 2023, 20:11 · Differential
valerio.bozzolan updated the test plan for D25359: Generate more fields in Download Raw Diff.
Aug 2 2023, 20:09 · Differential
valerio.bozzolan added a comment to D25359: Generate more fields in Download Raw Diff.

Nice. Let's file a Task for that. We can work with arc patch D25359 --skip-dependencies in the meanwhile

Aug 2 2023, 19:55 · Differential
avivey added a comment to D25359: Generate more fields in Download Raw Diff.

looks like arc patch tries to patch D25358 first, because this diff "Depends on" that one - but that one is in arcanist, not phorge.

Aug 2 2023, 19:46 · Differential
valerio.bozzolan added a comment to D25359: Generate more fields in Download Raw Diff.
$ phorge (master)> arc patch D25359
 INFO  Base commit is not in local repository; trying to fetch.
Branch name arcpatch-D25359 already exists; trying a new name.
Branch name arcpatch-D25359_1 already exists; trying a new name.
Created and checked out branch arcpatch-D25359_2.
 INFO  Base commit is not in local repository; trying to fetch.
Checking patch src/workflow/ArcanistExportWorkflow.php...
error: src/workflow/ArcanistExportWorkflow.php: does not exist in index
Checking patch src/parser/ArcanistBundle.php...
error: src/parser/ArcanistBundle.php: does not exist in index
Aug 2 2023, 19:44 · Differential
valerio.bozzolan added inline comments to D25305: Workboard: have thin scrollbars.
Aug 2 2023, 17:41
valerio.bozzolan attached a referenced file: F312323: Screenshot 2023-06-20 at 07-32-20 Editing-team (Kanban Board) · Workboard.png.
Aug 2 2023, 17:24
valerio.bozzolan attached a referenced file: F312321: Screenshot 2023-06-20 at 07-27-41 Editing-team (Kanban Board) · Workboard.png.
Aug 2 2023, 17:24
valerio.bozzolan updated the summary of D25305: Workboard: have thin scrollbars.
Aug 2 2023, 17:24
valerio.bozzolan added a comment to D25305: Workboard: have thin scrollbars.

Can you share a nice A/B test on Microsoft Windows to upload?

Aug 2 2023, 17:17
valerio.bozzolan retitled D25305: Workboard: have thin scrollbars from Use standard CSS properties for thin scrollbars
Aug 2 2023, 17:16
valerio.bozzolan accepted D25305: Workboard: have thin scrollbars.

Premising that I never manually "use" the scrollbar: I always use the mouse roll on desktop, or the finger swipe on mobile.

Aug 2 2023, 17:05
valerio.bozzolan updated the diff for D25305: Workboard: have thin scrollbars.

git rebase master

Aug 2 2023, 16:53
valerio.bozzolan accepted D25333: Fix DifferentialDiff getFieldValuesForConduit PHP 8.1 strlen(null) errors.

Soft+1 but let's wait for another +1. Thanks!

Aug 2 2023, 16:43
valerio.bozzolan added inline comments to D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.
Aug 2 2023, 16:37
valerio.bozzolan accepted D25357: Unify type-checking for `setHref()` type methods.

+1 with just that inline suggestion

Aug 2 2023, 16:34
valerio.bozzolan updated subscribers of D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 2 2023, 16:29
valerio.bozzolan accepted D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.

Tested, no nuclear implosions, thanks as usual :)

Aug 2 2023, 16:26
valerio.bozzolan updated the test plan for D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 2 2023, 16:24
valerio.bozzolan edited the content of Next Up.
Aug 2 2023, 15:15
valerio.bozzolan edited the content of Next Up.
Aug 2 2023, 15:14
valerio.bozzolan accepted D25362: Show more in Application Detail and List view.

Soft-accept! Tested and it works. Waiting for another tester.

Aug 2 2023, 13:26
valerio.bozzolan accepted D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.

Soft-accept. Thanks! I will test this a bit over additional integer fields

Aug 2 2023, 07:42
valerio.bozzolan edited the content of Next Up.
Aug 2 2023, 07:37

Aug 1 2023

aklapper requested review of D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:47
aklapper added a revision to T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy: D25371: Fix PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:47 · PHP 8 support
aklapper created T15581: PHP 8.1 "strlen(null)" exception creating Blueprint Working Copy.
Aug 1 2023, 17:43 · PHP 8 support
aklapper updated the diff for D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.

Remove unrelated Credentials change now covered in T15580 instead

Aug 1 2023, 17:34
aklapper updated the diff for D25239: Fix PHP 8.1 exceptions which block rendering Drydock's Create Blueprint page.

Handle empty $value in PhabricatorStandardCustomFieldPHIDs.php instead

Aug 1 2023, 17:31
aklapper requested review of D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:09
aklapper added a revision to T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential: D25370: Fix PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:09 · PHP 8 support
aklapper updated the task description for T15408: PHP 8.1 "json_decode(null)" exception blocks creating Almanac Hosts blueprint in Drydock.
Aug 1 2023, 17:09 · Almanac/Drydock/Harbormaster, PHP 8 support
aklapper created T15580: PHP 8.1 "strlen(null)" exception setting Passphrase Credential.
Aug 1 2023, 17:08 · PHP 8 support
avivey accepted D25346: Add HTML header for Atom/RSS discovery on Phame blog pages.

I think this should be implemented using the getHead() method that's already defined.

Could you elaborate a bit, please? I'm not sure what exactly not to do here, and what to do instead. Thanks in advance!

Aug 1 2023, 15:53
valerio.bozzolan added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.

clicking such a link w/javascript disabled will do nothing. Changing it to #123 and no JS will do something....

Aug 1 2023, 15:42 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
avivey added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.

Implicitly, Phorge generally works fine for browsers where Javascript is completely disabled.

Aug 1 2023, 15:20 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
avivey added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.
  1. Why these nice URLs are set in these links, if nobody visit them?
Aug 1 2023, 15:18 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan lowered the priority of T15578: The action "Quote comment" has an incomplete fragment URL from Low to Wishlist.

Less priority of course, since this Task I authored is super-stupid

Aug 1 2023, 15:13 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
aklapper added a comment to D25346: Add HTML header for Atom/RSS discovery on Phame blog pages.

I think this should be implemented using the getHead() method that's already defined.

Aug 1 2023, 15:01
valerio.bozzolan added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.

OK I've done my best :D I admit it helped me psychologically.

Aug 1 2023, 14:11 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan updated the task description for T15578: The action "Quote comment" has an incomplete fragment URL.
Aug 1 2023, 14:10 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
avivey added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.

If this is a feature request, then add all the things needed for a feature request - as in, "why would this feature be needed" and "what problem you're trying to solve".

Aug 1 2023, 12:40 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan added a project to T15578: The action "Quote comment" has an incomplete fragment URL: Feature Requests.

Is this a bug or a feature request?

Aug 1 2023, 12:39 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
avivey added a comment to T15578: The action "Quote comment" has an incomplete fragment URL.

Why would it need to be a that?
Is this a bug or a feature request?

Aug 1 2023, 12:32 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan updated the summary of D25369: Quote Comment: set meaningful URL.
Aug 1 2023, 12:19 · Comments
valerio.bozzolan claimed T15578: The action "Quote comment" has an incomplete fragment URL.

OK this was easy, but it really cannot be improved more than this in Legalpad or Phame. And this deserves a dedicated fix.

Aug 1 2023, 12:16 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan moved T15578: The action "Quote comment" has an incomplete fragment URL from Backlog to PingDeath 🌚 on the User-valerio.bozzolan board.
Aug 1 2023, 12:15 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan requested review of D25369: Quote Comment: set meaningful URL.
Aug 1 2023, 12:15 · Comments
valerio.bozzolan added a revision to T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page: D25369: Quote Comment: set meaningful URL.
Aug 1 2023, 12:15 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a revision to T15578: The action "Quote comment" has an incomplete fragment URL: D25369: Quote Comment: set meaningful URL.
Aug 1 2023, 12:15 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan added a comment to T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page.

I'm 99% sure that this only affects Phame and Legalpad. I tested in Audit, Maniphest, Paste, Pholio and Files without issues.

Aug 1 2023, 12:13 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan renamed T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page from Legalpad: "Quote Comment" destination is a "not found" page to Legalpad and Phame: "Quote Comment" destination is a "not found" page.
Aug 1 2023, 12:12 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a comment to F325667: Preview.png.
Aug 1 2023, 12:10
valerio.bozzolan added a comment to T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page.

This situation could be improved even more doing:

Aug 1 2023, 12:09 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan triaged T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page as Low priority.
Aug 1 2023, 12:09 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan created T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page.
Aug 1 2023, 12:09 · Phame, Bug Reports, User-valerio.bozzolan
valerio.bozzolan added a comment to T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants).

Increasing priority to normal since this feature is supposed to help to collaborate with others, but at the moment you only collaborate with yourself as default

Aug 1 2023, 11:42 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan raised the priority of T15163: The Task Cover Image is visible only to the uploader (invisible to Task participants) from Wishlist to Normal.
Aug 1 2023, 11:41 · Affects-Wikimedia, Maniphest, User-valerio.bozzolan, Cover Image, Workboard
valerio.bozzolan updated the name of F325778: Maniphest comment actions.png from "Screenshot_2023_08_01_131954.png" to "Maniphest comment actions.png".
Aug 1 2023, 11:20
valerio.bozzolan added a cover image to T15578: The action "Quote comment" has an incomplete fragment URL.
Aug 1 2023, 11:20 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan triaged T15578: The action "Quote comment" has an incomplete fragment URL as Low priority.
Aug 1 2023, 11:19 · Comments, Feature Requests, User-valerio.bozzolan, Maniphest
valerio.bozzolan edited the content of Next Up.
Aug 1 2023, 08:57
valerio.bozzolan added a comment to T15481: Support language highlighting for GitHub+StackOverflow+GitLab "Flavored Markdown" code blocks.

Should this be documented here? I think yes

Aug 1 2023, 08:08 · Feature Requests, Remarkup
valerio.bozzolan edited the content of Next Up.
Aug 1 2023, 08:07
valerio.bozzolan added a comment to T15366: Archived Panels: are still visible from Dashboard.

I'm mentioning this small thing in the Changelog since some people may have legacy Dashboards with a Panel that was Archived just to try. So there is less surprise on your Phorge homepage.

Aug 1 2023, 07:53 · Dashboards, User-valerio.bozzolan
valerio.bozzolan closed D25368: Hide Archived Panels from Dashboards.
Aug 1 2023, 07:51
valerio.bozzolan closed T15366: Archived Panels: are still visible from Dashboard as Resolved by committing rP840a7fab2bc8: Hide Archived Panels from Dashboards.
Aug 1 2023, 07:51 · Dashboards, User-valerio.bozzolan
valerio.bozzolan committed rP840a7fab2bc8: Hide Archived Panels from Dashboards.
Hide Archived Panels from Dashboards
Aug 1 2023, 07:51
valerio.bozzolan edited the content of Next Up.
Aug 1 2023, 07:50
valerio.bozzolan updated the diff for D25368: Hide Archived Panels from Dashboards.

fix comment

Aug 1 2023, 07:41
avivey accepted D25368: Hide Archived Panels from Dashboards.

LGTM, except for the comment text.

Aug 1 2023, 07:38
valerio.bozzolan added inline comments to D25368: Hide Archived Panels from Dashboards.
Aug 1 2023, 07:32

Jul 31 2023

valerio.bozzolan edited the content of Next Up.
Jul 31 2023, 15:44
valerio.bozzolan edited the content of Next Up.
Jul 31 2023, 15:44
bekay closed D25303: Implements a more informative hovercard for wiki documents.
Jul 31 2023, 15:33
bekay closed T15433: Hovercard of wiki article needs more information, a subtask of T15540: Improve more hovercards, as Resolved.
Jul 31 2023, 15:33
bekay closed T15433: Hovercard of wiki article needs more information as Resolved by committing rPdf3ac50cb742: Implements a more informative hovercard for wiki documents.
Jul 31 2023, 15:33
bekay committed rPdf3ac50cb742: Implements a more informative hovercard for wiki documents.
Implements a more informative hovercard for wiki documents
Jul 31 2023, 15:33
valerio.bozzolan added a comment to D25303: Implements a more informative hovercard for wiki documents.

Yeah just try "arc land" and, if it does not work, we can land this for you

Jul 31 2023, 15:15
bekay added a comment to D25303: Implements a more informative hovercard for wiki documents.

Okay, now how do I land this? Just arc land? Again, in my current setup there is no way of unit testing, so I don't know if it is possible...

Jul 31 2023, 15:14
bekay updated the diff for D25303: Implements a more informative hovercard for wiki documents.

Optimizes querying of project edges of multiple documents.

Jul 31 2023, 15:11
valerio.bozzolan added a comment to T15540: Improve more hovercards.

I don't think it's related ...

Jul 31 2023, 14:01
valerio.bozzolan triaged T15577: Show existing Hovercards from more places as Low priority.
Jul 31 2023, 14:00 · UX, User-valerio.bozzolan
valerio.bozzolan added a comment to T15540: Improve more hovercards.

Also maybe Macro app could deserve a nice Hovercard :)

Jul 31 2023, 14:00
valerio.bozzolan updated the task description for T15164: Resolving without Claiming causes error "Action with no effect".
Jul 31 2023, 13:04 · Maniphest, User-valerio.bozzolan
valerio.bozzolan updated the name of F325671: Preview before problem.png from "Screenshot_2023_07_31_150201.png" to "Preview before problem.png".
Jul 31 2023, 13:02
valerio.bozzolan updated the name of F325669: Unset.png from "Screenshot_2023_07_31_150107.png" to "Unset.png".
Jul 31 2023, 13:01
valerio.bozzolan updated the name of F325667: Preview.png from "Screenshot_2023_07_31_150003.png" to "Preview.png".
Jul 31 2023, 13:00