I'm quite sure we have to set PhabricatorApplicationTransaction.php::setIgnoreOnNoEffect(bool) somewhere but I don't know where ihih

In T15540#11723, @valerio.bozzolan wrote:

Partially related? Sometime I put my pointer hover the "Authored By <foo>" or similar fields, but they have no Hovercards. Probably easy-peasy?

Small issue in the query, but otherwise looks good.

Complete some issues.

Remove count.

In D25303#10646, @bekay wrote:

In D25303#10634, @valerio.bozzolan wrote:

Probably, the tags, if present, should be listed as last entry.

Would be, as already said, a big rewrite ...

In D25303#10634, @valerio.bozzolan wrote:

Probably, the tags, if present, should be listed as last entry. I suggest this since it's an info of variable-length, that is probably better in the footer.

Uh thanks!

Created repo rQR QR Stickers and project QR Codes Extension

Created repo rQR QR Stickers and project QR Codes Extension

Address code review comments

Yeah, we can use isset() and strlen() in place of phutil_nonempty_string(), and I'm happy to do it.

Premising that I liked this before, and I like this even more now,

I hope, this is now ready to land... sorry for the long delay 😅

Fix linting problem.

Use willRenderHovercards() to get all project and ancestor handles of potential multiple documents and rewrites inline SQL query.

In D25303#9015, @avivey wrote:

Showing project tags might be unique to tasks - Revisions don't show them, and neither do Owners or Commits. It might make sense not to show it here either.

In D25364#10593, @avivey wrote:

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

maybe add that as a comment in there...

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

maybe add that as a comment in there...

I've added a couple of screenshots

Request review for the second part of the change!

$edit_mode has a true value for 'create' or 'edit', and false (null) for read. The strlen() is superfluous.

In D25363#10531, @speck wrote:

Could this be abused, e.g. create an event with a thousand emails then import it and see if those emails are registered? If so how does that compare to existing means of discovering registered users?

Could this be abused, e.g. create an event with a thousand emails then import it and see if those emails are registered? If so how does that compare to existing means of discovering registered users?

Rebased with master and tested :) Nice thanks! Sorry for waiting

fix huge mistake from me