Differential D25369
Quote Comment: set meaningful URL Authored by valerio.bozzolan on Aug 1 2023, 12:15. Tags None Referenced Files
Subscribers
Details
If you visit most comments, now the "Quote Comment" has a specific I'm talking about the "Quote Comment" action here:  Destination before: https://we.phorge.it/T15322# Destination after: https://we.phorge.it/T15322#9867 This improves the situation everywhere but not in Legalpad or Phame Test the "Quote Comment" destination from:
Diff Detail
Event TimelineComment Actions Tested locally and works in most cases, however would love to avoid creating broken (404) URIs due to T15579 before merging Comment Actions I'm purely setting "Request Changes" to reflect that IMHO this should not get merged until there is an approach to fix T15579 - otherwise in some corner cases this proposed change would create broken URIs. For the time being, another hackish approach here could be querying which application context the TimelineEventView is in (if there's some kind of way for us to find out) and blocklisting Phame and Legalpad not to set $ref instead of #. Doesn't look easy to do either though. |