The action "Quote comment" has an incomplete fragment URL
Open, WishlistPublic
Actions

Description

I noticed that the destination URL of the button → Quote Comment is somehow too much generic than usual (just the anchor #).

1. Why have you noticed that?

I'm an average-experienced web user and I always look at the destination of any link before visiting them.

And so, I checked the destination of the link → Quote Comment, noticing that this was the destination:

https://we.phorge.it/T123#

And I think a link with # it's too much generic.

2. Why do you think that # is too much generic there?

I think it's too much generic because # is literally the most generic link in the world to make HTML happy and have JavaScript actions in place. And that is what there is in place: an event delegation that undoes your action, so you really does not visit that destination (the top of the page) but you do something else: quoting that comment.

But Phorge is usually better than that with destination links.

3. Why do you think that Phorge is usually better than that with destination links?

As an average Internet user I like the way Phorge has buttons and links with a meaning.

For example, this is the "internal" destination URL for the "Flags for Later" link:

https://we.phorge.it/flag/edit/PHID-TASK-3q2z3zqkzpm2nbvbeual/

Internal destination for the Start Tracking Time link:

https://we.phorge.it/phrequent/track/start/PHID-TASK-3q2z3zqkzpm2nbvbeual/

Internal destination for the "View Raw Remarkup":

https://we.phorge.it/transactions/raw/PHID-XACT-TASK-64ueghoon7ghftw/

Etc.

Usually the user never visit these resources but they are there.

4. Why these nice URLs are set in these links, if nobody visit them?

I think the main reason is: because Phorge can, easily, set nice destination URLs that somehow have semantically sense.

And so also → Quote Comment could have a destination that could have more semantically sense. For example, having the anchor to the current comment.

5. Why do you think that the anchor #comment-ID should be "internal destination" of that link?

Because I cannot thing about anything that is:

more better than #
less better than #comment-ID

And so the destination could be just from:

https://we.phorge.it/T123#

To:

https://we.phorge.it/T123#432

Revisions and Commits

rP Phorge
	Needs Review	D25369 Quote Comment: set meaningful URL

Related Objects

Mentioned In: T15597: Add a "Copy Link" to the comment drop-down menu
T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page

Event Timeline

valerio.bozzolan triaged this task as Low priority.Aug 1 2023, 11:19

valerio.bozzolan created this task.

valerio.bozzolan created this object in space S1 Public.

Herald added subscribers: Cigaryno, Matthew, chris and 2 others. · View Herald TranscriptAug 1 2023, 11:19

valerio.bozzolan set the cover image to F325778: Maniphest comment actions.png.Aug 1 2023, 11:19

valerio.bozzolan mentioned this in T15579: Legalpad and Phame: "Quote Comment" destination is a "not found" page.Aug 1 2023, 12:09

valerio.bozzolan added a revision: D25369: Quote Comment: set meaningful URL.Aug 1 2023, 12:15

OK this was easy, but it really cannot be improved more than this in Legalpad or Phame. And this deserves a dedicated fix.

Why would it need to be a that?
Is this a bug or a feature request?

Is this a bug or a feature request?

Not an obvious question. From an user perspective, this seemed like a bug.

Looking at the source code, this is clearly a missing stuff, so, this is a feature request. So let's flag as feature request.

I will update the description to reflect the expectations as feature request.

If this is a feature request, then add all the things needed for a feature request - as in, "why would this feature be needed" and "what problem you're trying to solve".

OK I've done my best :D I admit it helped me psychologically.

Less priority of course, since this Task I authored is super-stupid

Why these nice URLs are set in these links, if nobody visit them?

These links are all valid and usable - they do the right work, and do the expected thing (bring a form to perform the action).
They are there because it's possible to use them with javascript disabled.

This action only works in JS context, so it has the # fake url; Technically, clicking such a link w/javascript disabled will do nothing. Changing it to #123 and no JS will do something....

BTW, the button itself and all other "popup menus" (like "Edit Related Tasks "), and the buttons in remarkup controls also have a # url for the same reason - they only work with javascript.

Using # as the href for javascript-only "not-really-links" was common at some point - but it may have changed since to "have no href at all (and have other tricks to make it look like a link)".

Implicitly, Phorge generally works fine for browsers where Javascript is completely disabled.

clicking such a link w/javascript disabled will do nothing. Changing it to #123 and no JS will do something....

Surprisingly at the moment I think we have the opposite situation: with JavaScript disabled, if the user clicks on # it scrolls to the top. Instead, introducing #123 it will not scroll anywhere (you are already there at that comment).

valerio.bozzolan mentioned this in T15597: Add a "Copy Link" to the comment drop-down menu.Aug 9 2023, 07:55

The action "Quote comment" has an incomplete fragment URLOpen, WishlistPublicActions

Description

Revisions and Commits

Related Objects

Event Timeline

The action "Quote comment" has an incomplete fragment URL
Open, WishlistPublic
Actions